On Sun, Jul 10, 2016 at 2:19 AM, Bjørn Mork <bj...@mork.no> wrote: > Martin Blumenstingl <martin.blumensti...@googlemail.com> writes: > >> + if (of_property_read_bool(np, "qca,clk-25mhz")) >> + ah->is_clk_25mhz = true; >> + >> + if (of_property_read_bool(np, "qca,disable-2ghz")) >> + ah->disable_2ghz = true; >> + >> + if (of_property_read_bool(np, "qca,disable-5ghz")) >> + ah->disable_5ghz = true; > > This is bike-shedding, but how about > > ah->is_clk_25mhz = of_property_read_bool(np, "qca,clk-25mhz"); > ah->disable_2ghz = of_property_read_bool(np, "qca,disable-2ghz"); > ah->disable_5ghz = of_property_read_bool(np, "qca,disable-5ghz"); I'm fine with either way - I'll simply adhere to the coding style that the ath9k devs want to use, so just let me know which one you prefer. _______________________________________________ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
- Re: [ath9k-devel] [PATCH v4 1/3] Documentatio... Martin Blumenstingl
- Re: [ath9k-devel] [PATCH v4 1/3] Document... Arnd Bergmann
- Re: [ath9k-devel] [PATCH v4 1/3] Docu... Martin Blumenstingl
- Re: [ath9k-devel] [PATCH v4 1/3]... Arnd Bergmann
- Re: [ath9k-devel] [PATCH v4 1/3] Documentation: d... Kalle Valo
- Re: [ath9k-devel] [PATCH v4 1/3] Documentatio... Arnd Bergmann
- [ath9k-devel] [PATCH v4 2/3] ath9k: add a helper to ge... Martin Blumenstingl
- [ath9k-devel] [PATCH v4 3/3] ath9k: parse the device c... Martin Blumenstingl
- Re: [ath9k-devel] [PATCH v4 3/3] ath9k: parse the... Bjørn Mork
- Re: [ath9k-devel] [PATCH v4 3/3] ath9k: parse... Oleksij Rempel
- Re: [ath9k-devel] [PATCH v4 3/3] ath9k: parse... Martin Blumenstingl
- [ath9k-devel] [PATCH v5 0/3] add devicetree support to... Martin Blumenstingl
- [ath9k-devel] [PATCH v5 2/3] ath9k: add a helper ... Martin Blumenstingl
- [ath9k-devel] [PATCH v5 1/3] Documentation: dt: n... Martin Blumenstingl
- Re: [ath9k-devel] [PATCH v5 1/3] Documentatio... Arnd Bergmann
- Re: [ath9k-devel] [PATCH v5 1/3] Document... Martin Blumenstingl
- Re: [ath9k-devel] [PATCH v5 1/3] Docu... Arnd Bergmann
- [ath9k-devel] [PATCH v5 3/3] ath9k: parse the dev... Martin Blumenstingl
- [ath9k-devel] [PATCH v6 0/3] add devicetree suppo... Martin Blumenstingl
- [ath9k-devel] [PATCH v6 2/3] ath9k: add a hel... Martin Blumenstingl
- [ath9k-devel] [PATCH v6 3/3] ath9k: parse the... Martin Blumenstingl