Henry Ping wrote:
Instead of using #ifdef HELIX_FEATURE_SYMBIAN_MMF, can we create a new audio
device inheriting from the old one and put all the MMF stuff in there, i.e.
CHXMMFAudioDevice : public CHXAudioDevice
, public CHXAudDevStatusObserver
this seems to be cleaner way than using #ifdef.
The problem is that it is not a completely new audio device, it just
does a little extra. I agree that all those #ifdefs are ugly, but the
change is basically just adding a few lines to several functions. Those
functions would have to be duplicated in whole (well, perhaps) leading
to duplicate code and having to fix bugs in 2 places. If the code can
be structured in such a way as to avoid duplicating hunks of code then
I would be all for it. Rajesh?
--greg.
-->Henry
-----Original Message-----
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of
[EMAIL PROTECTED]
Sent: Tuesday, October 11, 2005 1:23 PM
To: [EMAIL PROTECTED]; audio-dev@helixcommunity.org
Subject: [Audio-dev] CR: Symbian Audio device loss detection
and handling(MMF profile)
"Nokia is bound by the terms of a commercial
contribution agreement with RealNetworks, and I am authorized
to contribute this code under said agreement."
Modified by: [EMAIL PROTECTED]
Reviewed by:
Date: 10-11-2005.
Project: Helix plugin for Symbian
Synopsis: Audio device loss detection and handling (MMF profile)
=======
Added the support for audio loss detection and
handling. This error could be thrown by the Devsound on the
event of incoming call, higher priority application taking
DevSound control, etc. The Audio interface will detect the
error and report to the ErrorMessages interface of the
context object. The controller will issue a pause on the
engine if the current state is playing or buffering and
inform the top level client of the error.
NOTE: The handling is added within the feature flag
HELIX_FEATURE_SYMBIAN_MMF
Files Modified:
===========
Audio\device\auddevlib_symbian.pcf
Audio\device\pub\platform\symbian\audsymbian.h
Audio\device\platform\symbian\audsymbian.cpp
Files Added:
=========
Audio\device\pub\platform\symbian\AudDevStatusObserver.h
Audio\device\platform\symbian\AudDevStatusObserver.cpp
Image Size and Heap Use impact: minor
Platforms and Profiles Build Verified:
helix-client-s60-mmf-basic, helix-client-s60-advanced
Platforms and Profiles Functionality verified: Armv5 (S60_3.0),
wins(S60_2.6)
Branch: helix
<<AudDevErr.diff>> <<Src.zip>>
_______________________________________________
Audio-dev mailing list
Audio-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/audio-dev
_______________________________________________
Audio-dev mailing list
Audio-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/audio-dev
