[EMAIL PROTECTED] wrote:
-----Original Message-----
From: ext Greg Wright [mailto:[EMAIL PROTECTED]
Sent: Tuesday, October 11, 2005 4:20 PM
Cc: Rathinasamy Rajesh (Nokia-TP-MSW/Dallas);
audio-dev@helixcommunity.org
Subject: Re: [Audio-dev] CR: Symbian Audio device loss
detection and handling(MMF profile)
Henry Ping wrote:
Instead of using #ifdef HELIX_FEATURE_SYMBIAN_MMF, can we
create a new
audio device inheriting from the old one and put all the MMF
stuff in there, i.e.
CHXMMFAudioDevice : public CHXAudioDevice
, public CHXAudDevStatusObserver
this seems to be cleaner way than using #ifdef.
The problem is that it is not a completely new audio device,
it just does a little extra. I agree that all those #ifdefs
are ugly, but the change is basically just adding a few lines
to several functions. Those functions would have to be
duplicated in whole (well, perhaps) leading to duplicate code
and having to fix bugs in 2 places. If the code can be
structured in such a way as to avoid duplicating hunks of code
then I would be all for it. Rajesh?
I agree with greg. We don't wanted to have much code duplication. The
changes are minimal in the old APIS. New set of API's are added which
are mostly helpers.
Actually this support can be extended for Symbian Helix player too. That
was my initial idea. But since the helix player does not handle this
error code, it ends up showing 'General Error' and based on severity
level of the error it stops playing the clip.
In MMF profile, the MMF controller understands the error and pauses the
engine. And later user can try continue to playout.
The new code checked in does not have any specific thing to MMF. It can
even be compiled for 2.6 except for the handling on the upper layer.
-Rajesh.
Perhaps you could just mask the code in clientapps/symbianplayer (a quick
hack is fine) and then we could remove all the #ifdefs right? Is all the
new code you added available in 7.0s and beyond?
--greg.
_______________________________________________
Audio-dev mailing list
Audio-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/audio-dev
