The smaller code size applies to both cases, just not entirely as small due to the size of the kobject. It's a pretty small structure, of which we use one per superblock. The scale makes any savings negligible.
The sysfs code is all static inline calls, so it carries no footprint when disabled. The use of kobjects removes quite a bit of code and would likely be brought up if it were to be merged upstream. -Jeff -- Jeff Mahoney (mobile) SUSE Labs On Apr 21, 2008, at 9:14 PM, [EMAIL PROTECTED] wrote: > > Hello Tomas and Jeff, > > Tomas M: >> I'm not sure if I understand you right, but I believe you are >> wondering if CONFIG_SYSFS is usually enabled in Linux distributions. >> >> I think it is enabled on ALL. > > Agreed. > > >> The only way to disable sysfs is when you set CONFIG_EMBEDDED=y, >> which is IMHO very rare. > > My *current* opinion is, as long as there is a way to disable SYSFS > aufs > should support such case. > > ---------------------------------------------------------------------- > > Jeff Mahoney: >> It would be helpful to understand your concerns here. aufs wouldn't >> be >> unconditionally dependent on sysfs any more than the rest of the >> kernel >> would be. If that were true, then the kernel would be littered with >> #ifdef CONFIG_SYSFS. Instead, sysfs provides no-op wrappers so that >> the >> kobject functionality is still intact but without being exported to >> sysfs. > > Currently aufs source files have a few such conditions, but the > actual/essential code is only one and it is just for accounting. > If we disable SYSFS for a small environment such like EMBEEDED or > something, the compiled aufs module will be smaller a little and > faster > just a little bit. And as you wrote, if aufs compiles SYSFS > unconditionally and handles the lifetime of some object, the source > code > will be slightly simple. > > Pros and cons, I am still considering... > > > Junjiro Okajima ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
