On 11/02/2012 10:34 PM, Eric Blake wrote:
> On 11/02/2012 03:19 PM, Eric Blake wrote:
>>
>> I wrote these off the cuff while composing the email, so they are
>> relatively untested.  And while re-reading, I see I botched the
>> self-redefinition, as well as failed to call AC_CONFIG_MACRO_DIR if the
>> first use was AC_CONFIG_MACRO_DIRS.  Here's another attempt, again
>> relatively untested.
> 
> Self-redefinition is a bit complex; how about this alternative?
> 
> [SNIP]
>
I believe some of the enhancements proposed here are definitely valuable
(e.g., the warning against multiple AC_CONFIG_MACRO_DIR).  But they
should be follow-up improvements over my patches, rather than squash-ins.
And they should have proper testsuite coverage too, IMNSHO.

Regards, and thanks,
  Stefano

Reply via email to