On Mon, 2011-02-28 at 17:03 +0800, Jason Wang wrote: > The following series tries to manage the tap by autotest. > We used to use qemu/qemu-ifup to manage the tap devices, which have serval > limitations: > > - We need to prepare a customized qemu-ifup script for the environment. > - Hard to integrate the macvtap support > > So this series tries to use the 'fd' params of qemu to create and manage the > tap > through autotest and drop the legacy qemu-ifup scirpt. > > --- > > Since this is just an RFC, so not all configuration of params for tap/bridge > was > implemented. > Macvtap integration is not included as it needs netlink related > fuction/libraries, ( but as a wrokaround, we can also create macvtap device > through ip command and open it by autotest).
Great, I liked your approach and I want to go forward with it, some little comments will go on the patches themselves. Is it too much work to create the netlink function libraries? If so, you can focus on the first part, which is the TAP management and at a later time, work on the macvtap integration. > Jason Wang (2): > KVM test: Add helpers to control the TAP/bridge > KVM test: setup tap fd and pass it to qemu-kvm > > > client/tests/kvm/kvm_utils.py | 109 > ++++++++++++++++++++++++++++++++ > client/tests/kvm/kvm_vm.py | 78 +++++++++++++++++++++-- > client/tests/kvm/scripts/qemu-ifup | 11 --- > client/tests/kvm/tests_base.cfg.sample | 3 - > 4 files changed, 181 insertions(+), 20 deletions(-) > delete mode 100755 client/tests/kvm/scripts/qemu-ifup > _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
