Hello, I am going to use TLSSocketFactory in my application and I would like to discuss some changes I am about to make and see how folks feel about them.
First, I am going to improve the javadocs: * move the configuration description to the top of the class (and replace those nasty <> with char entities) * specify the defaults for the configuration keys * maybe produce a schema file for the configuration (low priority for me plus I don't know xml schema syntax) Then, I don't see how authenticate-client is applicable to the _client_ connections this factory produces. So I propose to remove this notion altogether from the class. Finally, TLSSocketFactory has 3 public overloaded createSocket methods allowing one to wrap an existing socket into SSL. The problem with that is that these methods are not part of SocketFactory service. The methods themselves are genuinely useful, so I propose an extension of SocketFactory that specifies them and then we can have TLSSocketFactory provide both services. So how does the above sound? Thanks Greg -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
