[
https://issues.apache.org/jira/browse/AVRO-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801889#action_12801889
]
Doug Cutting commented on AVRO-135:
-----------------------------------
Looks good. Some comments:
- Should we, instead of a switch, have an abstract base class for codecs? It
could have methods like:
-- String getName();
-- Decoder expand(Decoder in);
-- void compress(byte[] buffer, int start, int end, Encoder out);
We can have a factory that creates a codec given a name, so that folks can
experiment with non-standard codecs without changing Avro.
- in the spec, you use the term "varint", not used elsewhere in that document.
- in the spec, we should be very clear on whether we're using gzip or deflate,
as these are often confused. my slight preference would be for deflate, since
it's more minimal, but i also realize that adding another level of CRC will
give lots of folks warm fuzzy feelings.
> add compression to data files
> -----------------------------
>
> Key: AVRO-135
> URL: https://issues.apache.org/jira/browse/AVRO-135
> Project: Avro
> Issue Type: New Feature
> Components: java, spec
> Reporter: Doug Cutting
> Assignee: Philip Zeyliger
> Priority: Blocker
> Fix For: 1.3.0
>
> Attachments: AVRO-135.patch.txt
>
>
> We should add support for at least one compression codec to data files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
