[ 
https://issues.apache.org/jira/browse/AVRO-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Zeyliger updated AVRO-135:
---------------------------------

    Attachment: AVRO-135.patch.txt

bq. can we change the terminology in the spec from "supported codecs" to 
"required codecs"? I think what we want to say is that using these names has 
defined semantics. Other strings are permitted, but we won't make any 
guarantees about what happens then.

Done.

bq. why isn't Codec public?

I'm hesitant to make that API public.  It's fine for stream-based compression, 
but I suspect that more awesome compression will come along that will make that 
API not be reasonable.  I'd rather cross the API bridge when someone requests 
it, but I could be convinced.

bq. write/uncompress are an odd pair of method names. why not compress/expand 
or somesuch?

compress/decompress it is.

bq. i don't see the point of adviseBufferSize(). why not just initialize 
compressionBuffer to new ByteArrayOutputStream(buffer.size()) the first time. 
ByteArrayOutputSTream will double it if it needs, but it probably won't, since 
the output should be substantially smaller than the input.

Fair enough; done.

bq. can we rename CodecOption to Codecs or CodecFactory?

CodecFactory it is.

bq. can we add a static method to define a new Codec?

Done.  Though because Codec isn't public, it's not of much use.

> add compression to data files
> -----------------------------
>
>                 Key: AVRO-135
>                 URL: https://issues.apache.org/jira/browse/AVRO-135
>             Project: Avro
>          Issue Type: New Feature
>          Components: java, spec
>            Reporter: Doug Cutting
>            Assignee: Philip Zeyliger
>            Priority: Blocker
>             Fix For: 1.3.0
>
>         Attachments: AVRO-135.patch.txt, AVRO-135.patch.txt, 
> AVRO-135.patch.txt, AVRO-135.patch.txt
>
>
> We should add support for at least one compression codec to data files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to