[
https://issues.apache.org/jira/browse/AVRO-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Zeyliger updated AVRO-386:
---------------------------------
Attachment: AVRO-386.patch.txt
Thanks for the review. Uploading new patch. If you want to see just what's
changed since the last one,
http://github.com/philz/avro/commit/3832584eebe545dfe7431ae8cc7bfa85e58ec430 .
bq. Remove the TODO's that you implemented
Removed one.
bq. In line 143, you set uncompressed_data = self.buffer_writer.getvalue(); use
this variable in line 149 instead of calling self.buffer_writer.getvalue()
again?
Done.
bq. Extra newline added after self.meta = {} in DataFileWriter#init_: remove
Done.
bq. Will "assert" raise a DataFileException? I haven't tried it.
It would have thrown an AssertionError (or something like that). Changed to
use DataFileException.
bq. Default "codec" to "'null'" instead of "None" in DFW#_init_?
I'm using "null" on purpose; that's the name of the "null codec" in AVRO.
bq. What are you up to in line 213 with self.codec = self.codec?
No idea; removed.
bq. Line 263 is wider than 80 characters
Done.
bq. Line 281: if you're skipping a long, why not use "skip_long()"? Not a big
deal.
Java doesn't have skip_long because it's the same performance. Switching to
skip; it's better.
> Python implementation of compression
> ------------------------------------
>
> Key: AVRO-386
> URL: https://issues.apache.org/jira/browse/AVRO-386
> Project: Avro
> Issue Type: Improvement
> Components: python
> Affects Versions: 1.3.0
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Attachments: AVRO-386.patch.txt, AVRO-386.patch.txt
>
>
> AVRO-135 introduced compression. AVRO-368 changed some metadata keys. The
> patch to follow adds this functionality to the python implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
