[
https://issues.apache.org/jira/browse/AVRO-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828943#action_12828943
]
Jeff Hammerbacher commented on AVRO-386:
----------------------------------------
Looks great, thanks!
One last comment:
bq. Default "codec" to "'null'" instead of "None" in DFW#init?
What I meant here: you assign "None" to the codec parameter as its default
value, but in the body of the function, the first thing you do with codec is
check to see if it's "None", and if so, set it to "'null'". It's not a big
deal, but I can see an argument for just using "'null'" as the default value
and skipping the check to see if it's "None". You lose the ability to check if
the parameter is unset, but you aren't using that ability right now. To be
honest, more of a question than a recommendation.
Otherwise, send it on in!
> Python implementation of compression
> ------------------------------------
>
> Key: AVRO-386
> URL: https://issues.apache.org/jira/browse/AVRO-386
> Project: Avro
> Issue Type: Improvement
> Components: python
> Affects Versions: 1.3.0
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Attachments: AVRO-386.patch.txt, AVRO-386.patch.txt
>
>
> AVRO-135 introduced compression. AVRO-368 changed some metadata keys. The
> patch to follow adds this functionality to the python implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
