On 26.03.2012 16:55, Alexander Yakushev wrote: > The problem was described here: > http://thread.gmane.org/gmane.comp.window-managers.awesome.devel/6921 > > The patch looks not very elegant but I don't know how to make it better > provided we want to save the "visible == true" functionality. I guess it > was done so that clicking some specific menu entry leaves menu unclosed > (does Awesome use it anywhere?). This means that menu must stay the > whole time while command executes and only after decide to close itself > (and subsequently stop keygrabber) or not. > > Patch is attatched.
This patch stops the keygrabber, but if the menu should continue running, the keygrabber is never restarted. The problem is that restarting the keygrabber could fail and I have no idea how that should be handled. Also I didn't even know that this "visible" feature exists. According to git blame, this was added in commit ea40a922 when awful.menu was rewritten. I guess I wouldn't mind dropping that and waiting for complaints. :-) CC'ing the author of said commit to see if he can shed some light on this. Dodo, why does awful.menu allow the functions for executing menu entries to return false in which case the menu isn't closed? What bad would happen if that is removed? Uli -- 'dubito ergo sum' -- Elke's whiteboard -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
