Hi Anthony,
The way Eclipse behaves makes sense to me, actually. Since WM_CLASS
should contain two strings - an 'app class' id and an 'app instance' id
- I'd have guessed that 'java' (or, rather, 'sun-awt-X11-XWindowPeer')
might be a good candidate for the 'class' id. And a string that
identifies a particular app instance might be, for example, the PID of
the JVM the app is running in.
Opinions?
[snip]
I agree, making this change as a separate fix sounds reasonable. Please
feel free to start a new thread on this mailing list and send the fix
for review.
I'll save the comments for the new thread then!
The fix looks very good. Thank you! Just a few stylistic remarks:
In src/solaris/native/sun/xawt/XToolkit.c
1) Please move the #include statements in the beginning of the source file.
Actually, I realized I no longer need string.h (old implementation
needed strlen). I moved the other #include to the bottom of the headers
list.
2) The JNI methods are supposed to have comments just before their
declarations, listing their Class, Method names, and its Signature.
Please see examples of such comments in the XToolkit.c file.
3) Native code uses slightly different code conventions than Java code,
and, in particular, we prefer to put the opening curly brace on a new
line after the function prototype.
4) Also, on the line 1108 please put a space between "if(" so that it
reads "if (".
5) We use 4 spaces to indent blocks of code.
Once this is done we'll be able to integrate the fix in JDK8.
Rest are done! New patch is at the same link[1]. Thanks for accepting it!
Regards,
Danesh
[1] http://icedtea.classpath.org/~ddadacha/tray_icon/
