I thought that /usr/libexec/java_home is a directory.
I have added ` ... ` and test works on solaris 10 and macosx.
http://cr.openjdk.java.net/~kshefov/8030640/webrev.01/

-Konstantin

On 21.03.2014 15:43, Anthony Petrov wrote:
Hi Konstantin,

/usr/libexec/java_home is an executable program (or script). You're assigning a path to this program to a variable that is supposed to hold a path to a JDK installation.

Could you please explain how you expect the above to work? What is the logic behind the change?

Also, how did you test your fix? I mean, surely, bash (or whatever shell is used) will now be happy with the syntax. But have you tried to actually make the bash and the test go through this case label and use the default JDK on the system?

--
best regards,
Anthony

On 3/21/2014 3:30 PM, Konstantin Shefov wrote:
Hello AWT team,

please review the fix
http://cr.openjdk.java.net/~kshefov/8030640/webrev.00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8030640

It is simple automatic test fix.

Thanks

-Konstantin

Reply via email to