Looks good to me. With best regards. Petr.
On 21.03.2014, at 16:01, Konstantin Shefov <konstantin.she...@oracle.com> wrote: > Updated and checked on Win, Solaris and OSX: > http://cr.openjdk.java.net/~kshefov/8030640/webrev.02/ > > On 21.03.2014 16:00, Petr Pchelko wrote: >> The new version is fine for me. But Sergey's suggestion is even better as >> the DEFAULT_JDK is not used.. >> Could you please update the fix? >> >> With best regards. Petr. >> >> On 21.03.2014, at 15:51, Anthony Petrov <anthony.pet...@oracle.com> wrote: >> >>> Thanks for the update. The fix looks fine now. >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 3/21/2014 3:49 PM, Konstantin Shefov wrote: >>>> I thought that /usr/libexec/java_home is a directory. >>>> I have added ` ... ` and test works on solaris 10 and macosx. >>>> http://cr.openjdk.java.net/~kshefov/8030640/webrev.01/ >>>> >>>> -Konstantin >>>> >>>> On 21.03.2014 15:43, Anthony Petrov wrote: >>>>> Hi Konstantin, >>>>> >>>>> /usr/libexec/java_home is an executable program (or script). You're >>>>> assigning a path to this program to a variable that is supposed to >>>>> hold a path to a JDK installation. >>>>> >>>>> Could you please explain how you expect the above to work? What is the >>>>> logic behind the change? >>>>> >>>>> Also, how did you test your fix? I mean, surely, bash (or whatever >>>>> shell is used) will now be happy with the syntax. But have you tried >>>>> to actually make the bash and the test go through this case label and >>>>> use the default JDK on the system? >>>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>>>> >>>>> On 3/21/2014 3:30 PM, Konstantin Shefov wrote: >>>>>> Hello AWT team, >>>>>> >>>>>> please review the fix >>>>>> http://cr.openjdk.java.net/~kshefov/8030640/webrev.00/ >>>>>> for the issue >>>>>> https://bugs.openjdk.java.net/browse/JDK-8030640 >>>>>> >>>>>> It is simple automatic test fix. >>>>>> >>>>>> Thanks >>>>>> >>>>>> -Konstantin >
