In general it looks fine to me. I will try to patch my local ws and run
some sanity test.
On 03.03.16 8:50, Rajeev Chamyal wrote:
Hello All,
Please review the updated webrev.
Added a free call for duplicate file name in splashscreen_sys.c ::
SplashGetScaledImageName
http://cr.openjdk.java.net/~rchamyal/8145173/webrev.02/
Regards,
Rajeev Chamyal
*From:*Rajeev Chamyal
*Sent:* 01 March 2016 15:45
*To:* awt-dev@openjdk.java.net; Sergey Bylokhov; Alexander Scherbatiy
*Subject:* RE: <AWT Dev> [9] Review request for JDK-8145173 HiDPI splash
screen support on Windows
Hello All,
Gentle reminder.
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8145173/webrev.01/
Regards,
Rajeev Chamyal
*From:*Rajeev Chamyal
*Sent:* 16 February 2016 16:01
*To:* awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net>; Sergey
Bylokhov; Alexander Scherbatiy
*Subject:* <AWT Dev> [9] Review request for JDK-8145173 HiDPI splash
screen support on Windows
Hello All,
Could you please review the following fix.
Bug : https://bugs.openjdk.java.net/browse/JDK-8145173
Webrev : http://cr.openjdk.java.net/~rchamyal/8145173/webrev.00/
This is an enhancement to support HiDPI splash screen on windows.
As a part of this enhancement implementation to
splashscreen_sys.c::SplashGetScaledImageName method has been provided.
System dpi and scale factor are used to determine the scaled image name.
Dpi value is read using GetDpiForMonitor API on Windows 8 and
GetDesktopDpi API on Windows 7.
Scale factor is calculated from the dpi value.
The naming convention followed for scaled image name is as follows:
Refer :
https://msdn.microsoft.com/en-us/library/windows/apps/xaml/hh965325.aspx
Unscaled image name : image.ext
Scaled image name : image.scale-<dpi value>./ext/
Regards,
Rajeev Chamyal
--
Best regards, Sergey.
