> On May 11, 2016, at 1:07 PM, Alexander Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > > > Hello, > > Could you review the fix: > bug: https://bugs.openjdk.java.net/browse/JDK-8154539 > webrev: http://cr.openjdk.java.net/~alexsch/8154539/webrev.00 > > This is a request from the jigsaw team to get rid of the dependency to > jdk.unsupported module from the java.desktop module. > The fix moves the sun.misc.SoftCache class to the sun.awt package in the > java.desktop module.
Looks okay. Moving sun.misc.SoftCache to java.desktop is fine. test/com/sun/jdi/ReferrersTest.java references sun.misc.SoftCache. I don’t know whether this test finds sun.misc.SoftCache in the reference graph at all. I suggest to update the test to check “sun.awt.SoftCache” instead and file a bug to the serviceability to follow up if that check is needed or not. Mandy
