Looks good.

--Semyon


On 11/15/2016 5:39 PM, Alexander Zvegintsev wrote:
Hi Sergey,

I've not found casting issues, but I've found the issue when previous fix does not

treat dynamically changed "apple.laf.useScreenMenuBar" property correctly. (e.g. ScreenMenuBarInputTwice test fails).

So please see the updated changeset:

http://cr.openjdk.java.net/~azvegint/jdk/9/8166683/01/

Thanks,
Alexander.

On 11/11/16 2:14 PM, Sergey Bylokhov wrote:
Hi, Alexander.
Did you run the tests on non-Aqua l&f? I assume that we can have a places in other l&f where we try to cast the MenuBarUI to some specific UI delegate.

On 09.11.16 16:58, Alexander Zvegintsev wrote:
Hello,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/9/8166683/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8166683

This fix adds support for ScreenMenuBar for L&F's other than Aqua.

With this fix it is enabled by default if apple.laf.useScreenMenuBar
property is true.

This behavior can be disabled by setting
apple.laf.disableForcedScreenMenuBar property to true.





Reply via email to