Looks fine.
> 5 дек. 2016 г., в 22:52, Alexander Zvegintsev
> <alexander.zvegint...@oracle.com> написал(а):
>
> Actually there is no need in this property, this behavior can be disabled for
>
> other L&F by setting apple.laf.useScreenMenuBar property to false.
>
> http://cr.openjdk.java.net/~azvegint/jdk/9/8166683/03/
>
> the fix is also reworked to remove mac specific stuff from shared code.
>
> Thanks,
> Alexander.
>
> On 11/29/16 4:12 AM, Alexander Zvegintsev wrote:
>> I don't find any modern jdk9 prefix convention for such property, so I've
>> named it "jdk.swing.disableForcedGlobalMenuBar"
>>
>> http://cr.openjdk.java.net/~azvegint/jdk/9/8166683/02/
>>
>>
>> Thanks,
>> Alexander.
>>
>> On 11/28/16 9:05 PM, Sergey Bylokhov wrote:
>>> Looks fine, but here is some of my thoughts:
>>> Since we tries to provide some kind of public API, I suggest to double
>>> check the solution again. In fact we tried to provide a support of the
>>> global menu on osx for all our L&Fs.
>>> - Is it necessary to reference the Aqua from the shared code? in variables
>>> names and properties? Probably something like "globalMenuBar", etc? At
>>> least this will allow us to change implementation in any ways on other
>>> platforms w/o changing/adding the old/new properties.
>>>
>>> On 15.11.16 17:39, Alexander Zvegintsev wrote:
>>>> Hi Sergey,
>>>>
>>>> I've not found casting issues, but I've found the issue when previous
>>>> fix does not
>>>>
>>>> treat dynamically changed "apple.laf.useScreenMenuBar" property
>>>> correctly. (e.g. ScreenMenuBarInputTwice test fails).
>>>>
>>>> So please see the updated changeset:
>>>>
>>>> http://cr.openjdk.java.net/~azvegint/jdk/9/8166683/01/
>>>>
>>>> Thanks,
>>>> Alexander.
>>>>
>>>> On 11/11/16 2:14 PM, Sergey Bylokhov wrote:
>>>>> Hi, Alexander.
>>>>> Did you run the tests on non-Aqua l&f? I assume that we can have a
>>>>> places in other l&f where we try to cast the MenuBarUI to some
>>>>> specific UI delegate.
>>>>>
>>>>> On 09.11.16 16:58, Alexander Zvegintsev wrote:
>>>>>> Hello,
>>>>>>
>>>>>> please review the fix
>>>>>>
>>>>>> http://cr.openjdk.java.net/~azvegint/jdk/9/8166683/00/
>>>>>>
>>>>>> for the issue
>>>>>>
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8166683
>>>>>>
>>>>>> This fix adds support for ScreenMenuBar for L&F's other than Aqua.
>>>>>>
>>>>>> With this fix it is enabled by default if apple.laf.useScreenMenuBar
>>>>>> property is true.
>>>>>>
>>>>>> This behavior can be disabled by setting
>>>>>> apple.laf.disableForcedScreenMenuBar property to true.
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>
