Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

[Prasanta Sadhukhan]

ok. The formatting is screwed up, needs to be rectified. Also l194, 
there should be a space before {

Regards
Prasantaa
On 14-Sep-18 2:45 PM, Krishna Addepalli wrote:

Thanks for the review Prasanta. Although there is not much difference 
between using fprintf and vfprintf, I have changed all the calls to 
vfprintf.

Here is the new webrev: 
http://cr.openjdk.java.net/~kaddepalli/8196681/webrev01/ 
<http://cr.openjdk.java.net/%7Ekaddepalli/8196681/webrev01/>

Krishna

*From:*Prasanta Sadhukhan
*Sent:* Friday, September 14, 2018 11:38 AM
*To:* Krishna Addepalli <krishna.addepa...@oracle.com>; 
awt-dev@openjdk.java.net
*Subject:* Re: <AWT Dev> RFR: [12] JDK-8196681: Java Access Bridge 
logging and debug flags dynamically controlled

One thing, since you are passing va_list as the last parameter, 
shouldn't all fprintf be actually vfprintf?

Regards
Prasanta

On 14-Sep-18 12:55 AM, Krishna Addepalli wrote:

    Hi All,

    Enhancement: https://bugs.openjdk.java.net/browse/JDK-8196681

    Webrev: http://cr.openjdk.java.net/~kaddepalli/8196681/webrev00/
    <http://cr.openjdk.java.net/%7Ekaddepalli/8196681/webrev00/>

    Please review an enhancement for supporting the logging of Java
    Access Bridge, so that customers/users facing problems with
    Accessibility can turn on/off logging to debug problems with this
    feature.

    The proposed solution is to have the user/developer define an
    environment variable “*JAVA_ACCESSBRIDGE_LOGFILE*” and filling
    with the path to the log file.

    The JavaAccessBridge will read the variable, and write to the file
    in the path provided.
    Note that the implementation is simplistic, and doesnot have any
    way to handle multiple applications, since it is a debug only feature.

    Thanks,

    Krishna