But this code is windows specific. So, it shouldn’t even be compiling on other platforms / compilers.
> On 14-Sep-2018, at 8:51 PM, Prasanta Sadhukhan > <prasanta.sadhuk...@oracle.com> wrote: > > Then I guess you need to do a mach5 run to ensure it compiles with all > compilers. > > Regards > Prasanta > On 14-Sep-18 8:33 PM, Krishna Addepalli wrote: >> Nullptr is the recommended way in modern c++. I thought of changing the >> other places as well, but wanted to keep the changes minimal, so left them >> as is. >> >> Thanks, >> Krishna >> >> From: Prasanta Sadhukhan >> Sent: Friday, September 14, 2018 5:48 PM >> To: Krishna Addepalli <krishna.addepa...@oracle.com> >> <mailto:krishna.addepa...@oracle.com>; awt-dev@openjdk.java.net >> <mailto:awt-dev@openjdk.java.net> >> Subject: Re: <AWT Dev> RFR: [12] JDK-8196681: Java Access Bridge logging and >> debug flags dynamically controlled >> >> one question: why nullptr is used? I see we used NULL in other places in >> this file, why cant we use the same? >> >> Regards >> Prasanta >> On 14-Sep-18 4:05 PM, Krishna Addepalli wrote: >> Thanks for the comments. Here is the new webrev: >> http://cr.openjdk.java.net/~kaddepalli/8196681/webrev02/ >> <http://cr.openjdk.java.net/%7Ekaddepalli/8196681/webrev02/> >> >> --Krishna >> From: Prasanta Sadhukhan >> Sent: Friday, September 14, 2018 3:23 PM >> To: Krishna Addepalli <krishna.addepa...@oracle.com> >> <mailto:krishna.addepa...@oracle.com>; awt-dev@openjdk.java.net >> <mailto:awt-dev@openjdk.java.net> >> Subject: Re: <AWT Dev> RFR: [12] JDK-8196681: Java Access Bridge logging and >> debug flags dynamically controlled >> >> ok. The formatting is screwed up, needs to be rectified. Also l194, there >> should be a space before { >> >> Regards >> Prasantaa >> On 14-Sep-18 2:45 PM, Krishna Addepalli wrote: >> Thanks for the review Prasanta. Although there is not much difference >> between using fprintf and vfprintf, I have changed all the calls to vfprintf. >> Here is the new webrev: >> http://cr.openjdk.java.net/~kaddepalli/8196681/webrev01/ >> <http://cr.openjdk.java.net/%7Ekaddepalli/8196681/webrev01/> >> >> Krishna >> >> From: Prasanta Sadhukhan >> Sent: Friday, September 14, 2018 11:38 AM >> To: Krishna Addepalli <krishna.addepa...@oracle.com> >> <mailto:krishna.addepa...@oracle.com>; awt-dev@openjdk.java.net >> <mailto:awt-dev@openjdk.java.net> >> Subject: Re: <AWT Dev> RFR: [12] JDK-8196681: Java Access Bridge logging and >> debug flags dynamically controlled >> >> One thing, since you are passing va_list as the last parameter, shouldn't >> all fprintf be actually vfprintf? >> >> Regards >> Prasanta >> On 14-Sep-18 12:55 AM, Krishna Addepalli wrote: >> Hi All, >> >> Enhancement: https://bugs.openjdk.java.net/browse/JDK-8196681 >> <https://bugs.openjdk.java.net/browse/JDK-8196681> >> Webrev: http://cr.openjdk.java.net/~kaddepalli/8196681/webrev00/ >> <http://cr.openjdk.java.net/%7Ekaddepalli/8196681/webrev00/> >> >> Please review an enhancement for supporting the logging of Java Access >> Bridge, so that customers/users facing problems with Accessibility can turn >> on/off logging to debug problems with this feature. >> The proposed solution is to have the user/developer define an environment >> variable “JAVA_ACCESSBRIDGE_LOGFILE” and filling with the path to the log >> file. >> The JavaAccessBridge will read the variable, and write to the file in the >> path provided. >> Note that the implementation is simplistic, and doesnot have any way to >> handle multiple applications, since it is a debug only feature. >> >> Thanks, >> Krishna >> >> >> > >
