Hi Martin, Le mer. 31 oct. 2018 à 17:03, Martin Balao <mba...@redhat.com> a écrit :
> Hi Sergey, > > Your MultipleContextsUnitTest test has 2 assertions that don't look good > to me: > > * dispatchSENumber < num1 > * dispatchSENumber < num2 > > My understanding is that these assertions mean that a non-SequencedEvent > event is expected to be synchronized with SequencedEvent events. If such > synchronization is needed, the event has to be wrapped in a SequencedEvent > event. There are no guarantees otherwise; previous to my proposal these > event were discarded and in my Webrev.02 they are dispatched asynchronously. > I think Sergey approach makes sense as awt events should happen on the proper window... > > I've tried your test -without these assertions- against my Webrev.02 and > it passes, as well as Laurent's 1st and 2nd test. > Thanks for your tests, could you try Sergey's patch too ? As I am on holidays, I did not have to test Sergey's patch, maybe tonight. I am really happy that this bug is going to be fixed soon, by either Martin or Sergey patch. Cheers, Laurent > Kind regards, > Martin.- > > > On Mon, Oct 29, 2018 at 3:06 PM, Sergey Bylokhov < > sergey.bylok...@oracle.com> wrote: > >> Hi, Martin. >> Thank you for this details description of the problem, I have tried to >> summarize it in this test, which should fail on all platforms: >> >> >> http://cr.openjdk.java.net/~serb/8204142/webrev.00/raw_files/new/test/jdk/java/awt/event/SequencedEvent/MultipleContextsUnitTest.java >> >> It creates a number of SequencedEvents and post them in a different >> orders. It also has some additional checks, for example InvocationEvent >> posted in between of SequencedEvents should be dispatched in the same order >> as posted/ or posted not early that SequencedEvents. Some new checks might >> be added. >> >> Here is another version of the fix which tries to resolve the problem >> covered by the test above: >> http://cr.openjdk.java.net/~serb/8204142/webrev.00/ >> >> But I have run it for a night in a bash loop, and it failed after 100+ >> iterations. So there is some room for improvements. >> >> Note that this fix should be applied on top of JDK-8211435: >> http://cr.openjdk.java.net/~serb/8211435/webrev.00/ >> >> >> On 26/10/2018 15:25, Martin Balao wrote: >> >>> >>> If you are talking about an example from this message: >>> >>> http://mail.openjdk.java.net/pipermail/awt-dev/2018-October/014426.html >>> <http://mail.openjdk.java.net/pipermail/awt-dev/2018-October/014426.html >>> > >>> >>> >>> That's only the first half of this issue, which is indeed easy to fix by >>> just dispatching SentEvent events. The second half is here: >>> http://mail.openjdk.java.net/pipermail/awt-dev/2018-October/014436.html >>> >> >> >> >> -- >> Best regards, Sergey. >> > >