Hi Prasanta,
Please find my answer inline to your comments:
Regards,
Manajit
> On 22-Nov-2018, at 12:03 PM, Prasanta Sadhukhan
> <prasanta.sadhuk...@oracle.com> wrote:
>
> Hi Manajit,
>
> I see in SwingSet2's InternalFrames Demo, when we create a new Frame with
> resizable and maximizable set and I maximize the window, then I am not able
> to resize the frame even without your fix. I thought it will allow me to
> resize without your fix, which is the bug you are trying to fix, right?
The problem is about resizing Frame with state MAXIMIZED_BOTH and this
state is set using setExtendedState. If I am not wrong MAXIMIZED_BOTH is not
used InternalFrameDemo.java. Without my fix a Frame with setExtendedState set
to MAXIMIZED_BOTH will resize if Frame is resizable on Mac.
> Also, in Windows10, I see when I create a new Frame with resizable and
> maximizable set, it is allowing me to resize the window
> but in mac, it is now allowing me to resize with/without your fix.
Was the Frame extendedState set to MAXIMIZED_BOTH in this case? The
attached test case with the fix doesn’t allow the Frame to resize on Window and
Ubuntu.
>
> Regards
> Prasanta
> On 13-Nov-18 2:07 PM, Manajit Halder wrote:
>> Hi All,
>>
>> Gentle remainder. Please review this fix.
>>
>> Regards,
>> Manajit
>>
>>
>> On 08/10/18 10:27 AM, Krishna Addepalli wrote:
>>> Looks fine.
>>>
>>> Krishna
>>>
>>> From: Manajit Halder
>>> Sent: Thursday, October 4, 2018 6:01 PM
>>> To: Krishna Addepalli <krishna.addepa...@oracle.com>
>>> <mailto:krishna.addepa...@oracle.com>; awt-dev@openjdk.java.net
>>> <mailto:awt-dev@openjdk.java.net>
>>> Subject: Re: <AWT Dev> <AWT dev>[12] Review request for JDK-8209123:
>>> [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu
>>>
>>> Hi Krishna,
>>>
>>> Thanks for your review comments. Answers are updated inline to your queries.
>>>
>>> Please review the modified webrev:
>>> http://cr.openjdk.java.net/~mhalder/8209123/webrev.01/
>>> <http://cr.openjdk.java.net/%7Emhalder/8209123/webrev.01/>
>>> Thanks,
>>> Manajit
>>>
>>>
>>>
>>> On 04/10/18 8:13 AM, Krishna Addepalli wrote:
>>> Hi Manajit,
>>>
>>> I have some questions which need to be answered:
>>> 1. You have same piece of code repeated in “setWindowState” and in
>>> “setVisible” functions, which tests if the frame is resizable flag is
>>> changed and sets the state to false. Is it not true that setWindowState
>>> will be called before setVisible, and if so, then why do you need to check
>>> twice?
>>> The code has to be repeated at places where window state is changing.
>>> Both the methods setWindowState and setVisible calls methods maximize() and
>>> unmaximize() where window state is changing to a new state.
>>>
>>> 2. In the deliverDoubleClickOnTitleBar() function, you may want to
>>> include a note which describes why you are temporarily enabling the
>>> resizable flag, and posting a native event, and then enabling the flag.
>>> Added comment.
>>>
>>> 3. At line 825, you could initialize windowResizable like this:
>>> “resizable && !isMaximizedBoth()”.
>>> Changed code as per the comment.
>>>
>>>
>>> Thanks,
>>> Krishna
>>>
>>>
>>> From: Manajit Halder
>>> Sent: Tuesday, September 25, 2018 3:23 PM
>>> To: Krishna Addepalli <krishna.addepa...@oracle.com
>>> <mailto:krishna.addepa...@oracle.com>>
>>> Subject: Re: <AWT Dev> <AWT dev>[12] Review request for JDK-8209123:
>>> [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu
>>>
>>> Hi Krishna,
>>>
>>> Could you please review my fix.
>>>
>>> Regards,
>>> Manajit
>>>
>>>
>>> On 21/09/18 5:07 PM, Manajit Halder wrote:
>>> Hi All,
>>>
>>> Please review the fix for JDK12.
>>>
>>>
>>>
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8209123
>>> <https://bugs.openjdk.java.net/browse/JDK-8209123>
>>>
>>> Webrev:
>>>
>>> http://cr.openjdk.java.net/~mhalder/8209123/webrev.00/
>>> <http://cr.openjdk.java.net/%7Emhalder/8209123/webrev.00/>
>>> Fix:
>>>
>>> Resizibility of Frame with state MAXIMIZED_BOTH is set to false when
>>> Frame is resized and when Frame state is set. Resizibility of Frame in
>>> other states (NORMAL and ICONIFIED) is changed if the previous state of the
>>> frame was MAXIMIZED_BOTH otherwise it is not changed.
>>>
>>> Changes in method setResizable()
>>> 1) if setResizable passed true, then check if frame is in MAXIMIZED_BOTH
>>> state, if so then set setResizable to false, otherwise set to true.
>>> 2) if setResizable passed false, then set false without checking the frame
>>> MAXIMIZED_BOTH state.
>>>
>>> Changes done in method setVisible and setWindowState where Frame state is
>>> set:
>>> 1) Before setting any state check if resizibility was changed to
>>> MAXIMIZED_BOTH earlier, if so then set resizibility to false.
>>> 2) When Frame state is set to MAXIMIZED_BOTH then set resizibility to
>>> false.
>>>
>>> JCK and Jtreg (open and close) tests executed with the change:
>>> 1) All automated AWT and Swing tests.
>>> 2) All manual AWT and Swing tests related to Frame, Window, JFrame and
>>> JWindow.
>>>
>>>
>>> Regards,
>>>
>>> Manajit
>>>
>>>
>>>
>>>
>>>
>>
>
>
