On Fri, 18 Dec 2020 11:11:52 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D >> code > > src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m line 743: > >> 741: if (printerJob == NULL) return NO; >> 742: GET_NSPRINTINFO_METHOD_RETURN(NO) >> 743: NSPrintInfo* printInfo = >> (NSPrintInfo*)jlong_to_ptr((*env)->CallLongMethod(env, printerJob, >> sjm_getNSPrintInfo)); // AWT_THREADING Safe (known object) > > CHECK_EXCEPTION? I've fixed a bunch of these but some - like this one - do not need CHECK_EXCEPTION. We detect a null return value and return directly to Java and we are better to propagate any theoretical exception in such cases. ------------- PR: https://git.openjdk.java.net/jdk/pull/1679
