Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v3]

[Gerard Ziemski]

On Wed, 10 Feb 2021 21:40:46 GMT, Gerard Ziemski <gziem...@openjdk.org> wrote:

>> Changes requested by gziemski (Committer).
>
> I tried to code review the native implementation files, but Metal APIs is 
> brand new to me and it's been a long while since I worked with graphics API, 
> so I can't be of much help really.
> 
> The code I've looked at looked clean and nothing caught my eye. But it's a 
> partial code review at best.
> 
> Good job!

A small thing caught my eye when I was comparing OpenGL and Metal pipelines 
running J2Demo.jar

It looks to me like OpenGL rendering pipeline uses brighter colors. I prefer 
the more subdued colors that Metal is rendering, but not sure if this is 
something you want to investigate further.

I tried to capture what I see below:

OpenGL:

<img width="1128" alt="OpenGL" 
src="https://user-images.githubusercontent.com/63425797/107575744-dc0ca180-6bb5-11eb-9eb3-5cff415eb8a3.png";>

Metal (the green color has a yellowish tint):

<img width="1125" alt="Metal" 
src="https://user-images.githubusercontent.com/63425797/107575716-cf884900-6bb5-11eb-8ae8-14212ec94e87.png";>

Performance wise I did not see much difference either way.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2403