[
https://issues.apache.org/jira/browse/AXIS2C-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569715#action_12569715
]
Sahan Gamage commented on AXIS2C-645:
-------------------------------------
Even in the execution perspective I don't see an extra dependency by doing
this. If what you're arguing is correct then passing conf_ctx to the
module_init() is also a violation of the abstraction.
The idea was, if the module do something with the conf_ctx at the
initialization (and subsequent execution of it's handlers) then it should undo
that before exit in order to maintain the correct state. Having a table inside
the module and keep track of the changes is one way of doing that. But I would
consider that as a "hack" rather than the proper method.
I don't agree with the last point. The module knows what it did push to the
conf_ctx as properties and hence it has a good idea about how to pull them out
and clean it. Core may not have any idea about the data inside these objects -
so module has much more control over cleaning up module specific properties.
> Need to pass configuration context to axis2_module_shutdown()
> -------------------------------------------------------------
>
> Key: AXIS2C-645
> URL: https://issues.apache.org/jira/browse/AXIS2C-645
> Project: Axis2-C
> Issue Type: Improvement
> Components: core/description
> Affects Versions: Current (Nightly)
> Reporter: Sahan Gamage
> Priority: Minor
>
> We need to pass configuration context to module shutdown function since
> modules might have pushed module specific data as parameters to configuration
> context. Cleaning module specific data by the module itself and not by the
> axis2 core is the most suitable way I believe.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
