Hi, It's my mistake, I forgot to look at the method signature. The compilation warning can be caused by the fact that the function is static.
Thanks Milinda On Fri, May 23, 2008 at 2:36 PM, Steven Nairn <[EMAIL PROTECTED]> wrote: > The function axutil_hash_entry_free() is a static function (in both > 1.4.0 and trunk). Therefore it can only be used in hash.c and is not > (and cannot be) part of the API. > > It's not used in hash.c so I think it should be removed. > > Cheers, > Steve Nairn > > 2008/5/23 Dimuthu Gamage <[EMAIL PROTECTED]>: > > Yea, I agreed with Milinida, There are API functions that is not used > > anywhere inside Axis2. But used in some time codegen generated code or > > some other places like even wsf/php. So I think it is valid to have > > API functions not used inside axis2. > > > > Thanks > > Dimuthu > > > > On Fri, May 23, 2008 at 10:58 AM, Milinda Pathirage > > <[EMAIL PROTECTED]> wrote: > >> For example take function like 'axutil_date_time_is_utc' and runa grep > on > >> Axis2/C source. This function is never used in our code. But we have > >> implemented it and one who implement service or client might use it in > >> his/her code. This kind of functions are there to provide consistent API > to > >> the users who use this library to write their own services/clients. So I > >> think it's better not to use -Wunused-function flag (Currently we are > using > >> -Wall in Axis2/C build and we will have to use seperate warning flags if > we > >> encounter this kind of problems in future with new version of > compilers). > >> > >> Thanks > >> Milinda > >> > >> On Fri, May 23, 2008 at 10:39 AM, Chintana Wilamuna < > [EMAIL PROTECTED]> > >> wrote: > >>> > >>> On Fri, May 23, 2008 at 10:22 AM, Chintana Wilamuna < > [EMAIL PROTECTED]> > >>> wrote: > >>> > >>> > Um .. I don't agree. This was found because of the "new changes to > >>> > gcc". Which is really helpful because it caught a function which is > >>> > not used anywhere. If it's not used why it's defined in the first > >>> > place? Why not remove it altogether until it's used somewhere. > >>> > Otherwise it'll take us nowhere because a defined function is not > used > >>> > anywhere ;-) > >>> > >>> Milinda told me that there could be a function defined in axutil/axis2 > >>> etc... and that not being used anywhere throughout the code. Sorry I > >>> didn't know that. In that case yeah, should change the build system. > >>> > >>> Bye, > >>> > >>> -Chintana > >>> > >>> -- > >>> http://engwar.com/ > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: [EMAIL PROTECTED] > >>> For additional commands, e-mail: [EMAIL PROTECTED] > >>> > >> > >> > >> > >> -- > >> http://mpathirage.com > >> http://wso2.org "Oxygen for Web Service Developers" > >> http://wsaxc.blogspot.com "Web Services With Axis2/C" > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- http://mpathirage.com http://wso2.org "Oxygen for Web Service Developers" http://wsaxc.blogspot.com "Web Services With Axis2/C"
