For instance (not to pick on just you roshan): "after introducing new Serializer interfaces IWrapperSoapSerializer and IHandlerSoapSerializer"
was submitted in about 8+ commits. 1 would be better. -- Tom Jordahl Macromedia Server Development -----Original Message----- From: Tom Jordahl [mailto:[EMAIL PROTECTED] Sent: Monday, July 28, 2003 10:05 AM To: '[EMAIL PROTECTED]' Subject: RE: C++ commits Sanjiva, What (I thought) I was seeing was *related* file changes, many times with the same check in comment, being done in individual submits. This is what I was hoping to get clumped in to a single check-in. I have no problem with individual changes having different commits, but at this early stage of the C++ project, it just seems that if user X has a bunch of files to check in, they might as well do it all together and detail what they did in a comprehensive comment. -- Tom Jordahl Macromedia Server Development -----Original Message----- From: Sanjiva Weerawarana [mailto:[EMAIL PROTECTED] Sent: Thursday, July 24, 2003 11:13 PM To: [EMAIL PROTECTED] Subject: Re: C++ commits IMHO its better to have separate commits .. its easier for someone to monitor the commits ;-). How would you like if Dims kept doing monster commits? Maybe its time to create axis-dev-c and axis-dev-j lists? Personally I'd rather keep the family together yet, but if its bothering people then we need to do something. Tom, would an additional mail filter solve the immediate problem for you? Sanjiva. ----- Original Message ----- From: "Tom Jordahl" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Thursday, July 24, 2003 9:10 PM Subject: C++ commits > > It would be super cool if you all could combine the (related) C++ code submissions in to a single commit. This make it easier for people to either review (or not) your checkins. > > Sometimes its scary to see 50 unread messages in axis-dev. :-) > > Thanks! > -- > Tom Jordahl > > > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: Wednesday, July 23, 2003 11:52 PM > To: [EMAIL PROTECTED] > Subject: cvs commit: xml-axis/c/src/wcg WSClass.cpp > > > susantha 2003/07/23 20:51:32 > > Modified: c/src/wcg WSClass.cpp > Log: > now WCG can generate wrapper classes for web services that passes and returns complex types as well but not arrays > > Revision Changes Path > 1.4 +2 -2 xml-axis/c/src/wcg/WSClass.cpp > > Index: WSClass.cpp > =================================================================== > RCS file: /home/cvs/xml-axis/c/src/wcg/WSClass.cpp,v > retrieving revision 1.3 > retrieving revision 1.4 > diff -u -r1.3 -r1.4 > --- WSClass.cpp 18 Jul 2003 13:31:44 -0000 1.3 > +++ WSClass.cpp 24 Jul 2003 03:51:31 -0000 1.4 > @@ -194,7 +194,7 @@ > file << "}" << endl; > file << endl; > > - file << "void" << m_Name << "::OnFault(IMessageData* pMsg)" << endl; > + file << "void " << m_Name << "::OnFault(IMessageData* pMsg)" << endl; > file << "{" << endl; > file << "}" << endl; > file << endl; > @@ -216,7 +216,7 @@ > file << "\tstring method = name;" << endl; > file << "\tISoapMethod* pMethod = mc->getSoapSerializer()->createSoapMethod();" << endl; > file << "\tpMethod->setLocalName(method + \"Response\");" << endl; > - file << "\tpMethod->setPrefix(\"" << "amp" << "\");"<< endl; //amp - axis method prefix :) > + file << "\tpMethod->setPrefix(" << "mc->getSoapSerializer()->getNewNamespacePrefix()" << ");"<< endl; //amp - axis method prefix :) > file << "\tpMethod->setUri(\"" << g_ClassNamespaces[m_AWSName] << "\");"<< endl; //http://www.opensource.lk will come from wsdd > file << "\treturn SUCCESS;" << endl; > file << "}" << endl; > > >
