Note that there will possibly be changes needed on axis2 side as well. One another criteria is to make sure we don't break any tests in existing Axis2 harness.
When we get to that point, we need to run end-to-end test with axis2 client <-> axis2 server with mutiple payload sizes. Until then, i'd support the new code as an option. Not the default. thanks, dims On Thu, Nov 20, 2008 at 10:37 AM, Ruwan Linton <[EMAIL PROTECTED]> wrote: > I guess what you are saying is that we need to check the performance of > Axiom with this patch right? If so why not we do this right now and commit > the patch? > > Any volunteers to do this? ;-) > > Thanks, > Ruwan > > On Thu, Nov 20, 2008 at 8:01 PM, Davanum Srinivas <[EMAIL PROTECTED]> wrote: > >> Ruwan, >> >> If you see my -1...i said we should not check it in a"as-is". >> >> We should make changes such that MIME4J is an alternate >> implementation. When we are finally convinced that it is better then >> what we have (when running all the different MTOM size attachments), >> then we should switch that to be the default. >> >> Makes sense? >> >> thanks, >> dims >> >> On Thu, Nov 20, 2008 at 9:24 AM, Ruwan Linton <[EMAIL PROTECTED]> >> wrote: >> > Dims, >> > >> > I am sorry, I cannot find the reasoning that you are referring. Now that >> > Oleg did the differed passing part that Thilina suggested, I think it is >> in >> > a good shape. >> > >> > If I am missing anything, can you please explain the reason of not >> > committing this patch? >> > >> > Thanks, >> > Ruwan >> > >> > On Thu, Nov 20, 2008 at 7:29 PM, Davanum Srinivas <[EMAIL PROTECTED]> >> wrote: >> >> >> >> Please see my previous emails. >> >> >> >> -- dims >> >> >> >> On Thu, Nov 20, 2008 at 8:48 AM, Sanjiva Weerawarana >> >> <[EMAIL PROTECTED]> wrote: >> >> > For what reason? If you decide to veto then you should have the >> courtesy >> >> > to >> >> > give a reason. >> >> > >> >> > Sanjiva. >> >> > >> >> > Davanum Srinivas wrote: >> >> >> >> >> >> -1 to checking in the patch as-is. >> >> >> >> >> >> thanks, >> >> >> dims >> >> >> >> >> >> On Thu, Nov 20, 2008 at 8:23 AM, Sanjiva Weerawarana >> >> >> <[EMAIL PROTECTED]> wrote: >> >> >>> >> >> >>> Oleg Kalnichevski wrote: >> >> >>>> >> >> >>>> I have commit rights for Synapse, but I do not recall ever being >> >> >>>> granted >> >> >>>> WS commit rights. >> >> >>> >> >> >>> With the transport move you do now. >> >> >>> >> >> >>> Thilina, while I agree with "don't fix if it ain't broke", this is >> an >> >> >>> *improvement* .. not a fix for the sake of a fix. I think we should >> do >> >> >>> it. >> >> >>> >> >> >>> If it breaks something (like interop) we can always revert .. >> >> >>> >> >> >>> Sanjiva. >> >> >>> -- >> >> >>> Sanjiva Weerawarana, Ph.D. >> >> >>> Founder & Director; Lanka Software Foundation; >> >> >>> http://www.opensource.lk/ >> >> >>> Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/ >> >> >>> Member; Apache Software Foundation; http://www.apache.org/ >> >> >>> Visiting Lecturer; University of Moratuwa; >> http://www.cse.mrt.ac.lk/ >> >> >>> >> >> >>> Blog: http://sanjiva.weerawarana.org/ >> >> >>> >> >> >> >> >> >> >> >> >> >> >> > >> >> > >> >> > -- >> >> > Sanjiva Weerawarana, Ph.D. >> >> > Founder & Director; Lanka Software Foundation; >> http://www.opensource.lk/ >> >> > Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/ >> >> > Member; Apache Software Foundation; http://www.apache.org/ >> >> > Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/ >> >> > >> >> > Blog: http://sanjiva.weerawarana.org/ >> >> > >> >> >> >> >> >> >> >> -- >> >> Davanum Srinivas :: http://davanum.wordpress.com >> > >> > >> > >> > -- >> > Ruwan Linton >> > http://wso2.org - "Oxygenating the Web Services Platform" >> > http://ruwansblog.blogspot.com/ >> > >> >> >> >> -- >> Davanum Srinivas :: http://davanum.wordpress.com >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> > > > -- > Ruwan Linton > http://wso2.org - "Oxygenating the Web Services Platform" > http://ruwansblog.blogspot.com/ > -- Davanum Srinivas :: http://davanum.wordpress.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
