Hi, > >> Thilina, while I agree with "don't fix if it ain't broke", this is an > *improvement* .. not a fix for the sake of a fix. I think we should do it.
As even Oleg mentioned the MIME4J is around 15% slower than the current impl.. IMHO the issue which this patch tries to address (in memory buffering of SOAP part) is not much of an issue when used with attachments, cause most of the time people use small soap envelopes when they use attachments. Also I'm not sure whether MIME4J is as battle tested as the Axis2's current implementation. I totally agree that we should support MIME4J and we should do "improvements".. But since this does not come with any urgent fixes for something that's badly broken, I would prefer to do it in a little bit of a controlled fashion.. May be support both the impl's or do this in a branch first. Also I'm sorry, but I don't really like the approach people are taking in this issue.. Why is it that the decision is between commit the patch directly to trunk or throw away... Why cant' we come to a middle ground.. thanks, Thilina > > If it breaks something (like interop) we can always revert .. > > Sanjiva. > -- > Sanjiva Weerawarana, Ph.D. > Founder & Director; Lanka Software Foundation; http://www.opensource.lk/ > Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/ > Member; Apache Software Foundation; http://www.apache.org/ > Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/ > > Blog: http://sanjiva.weerawarana.org/ > -- Thilina Gunarathne - http://thilinag.blogspot.com
