On Monday, 27. January 2003 18:44, Matt Sergeant wrote:
> Can someone with more brane power than me go over these patches for
> sanity?
I disagree with these patches:
if (!$recreate) {
AxKit::Debug(1, "delivering cached copy - all conditions met");
- return $cache->deliver();
+ return OK;
}
Here was that nice DECLINED hack which made Apache deliver the cached file
with all the Etag, If-Modified-Since, ... bells and whistles. The manual
delivery implemented further down the patch imposes extra reading and
copying.
Moreover, AxOutputTransformer was designed to be _behind_ the cache. This
patch puts it before the cache. If it is used for anything cacheable, it's
purpose wasn't understood.
--
CU
Joerg
PGP Public Key at http://ich.bin.kein.hoschi.de/~trouble/public_key.asc
PGP Key fingerprint = D34F 57C4 99D8 8F16 E16E 7779 CDDC 41A4 4C48 6F94
