Re: [B.A.T.M.A.N.] [PATCH 03/11] batman-adv: Send neighbor discovery packets

[Andrew Lunn]

> diff --git a/batman-adv/ndp.c b/batman-adv/ndp.c
> index 60631b0..3269d67 100644
> --- a/batman-adv/ndp.c
> +++ b/batman-adv/ndp.c
> @@ -49,10 +49,21 @@ static void ndp_send(struct work_struct *work)
>       struct batman_if *batman_if = container_of(work, struct batman_if,
>                                                       ndp_wq.work);
>       struct bat_priv *bat_priv = netdev_priv(batman_if->soft_iface);
> +     struct batman_packet_ndp *ndp_packet;
> +     struct sk_buff *skb;
> +
> +     skb = skb_copy(batman_if->ndp_skb, GFP_ATOMIC);
> +     ndp_packet = (struct batman_packet_ndp *)skb->data;

Hi Linus

You should check the returned skb. It could be NULL if the system is
out of memory.

    Andrew