Hi Sven,

Here you can get the two files

PATCHED VIS.C

http://dev.villagetelco.org/svn/villagetelco/server/trunk/src/install/vis/vis.c

and

http://dev.villagetelco.org/svn/villagetelco/server/trunk/src/install/vis/vis.c.patch

The patch was applied against the version

http://downloads.open-mesh.org/batman/releases/batman-0.3.2/vis-0.3.2.tar.gz


* The patch fixes three issues
 - Reporting of duplicated entries in the VIS output, this is fixed in
trunk but not in vis.0.3.2
 - Removed a gcc warning related to the use of chdir()
 - Cleaned up the JSON output of vis

Our code is in SVN so I have not git-send-email magic :)

-aep


On 03/09/2011 06:04 PM, Sven Eckelmann wrote:
> On Wednesday 09 March 2011 17:48:32 elektra wrote:
>> The current vis server JSON output format is breaking the json_decode()
>> function for PHP.
>>
>> This patch mainly:
>> - Removes all spaces
>> - Removes all the \t TABS
>> - Double quotes the string-variables
>>
>> Reported-by:  "Alberto Escudero-Pascual" <a...@it46.se>
>> Signed-off-by: "elektra" <onelek...@gmx.net>
> 
> I am not sure if anyone currently maintains batmand and vis.
> 
> Anyway, your patch is more or less scrambled. Can you please resend it using 
> a 
> client which doesn't create a wordwrap and space massacre[1]. Many people 
> here 
> seem to use git-send-email for that purpose.
> 
> Kind regards,
>       Sven
> 
> [1] http://kernel.org/doc/Documentation/email-clients.txt

Reply via email to