From: Antonio Quartulli <[email protected]>
Date: Wed,  9 May 2012 13:12:49 +0200

> From: Marek Lindner <[email protected]>
> 
> Signed-off-by: Marek Lindner <[email protected]>
> Acked-by: Simon Wunderlich <[email protected]>
> Signed-off-by: Antonio Quartulli <[email protected]>

The namespace pollution of the batman-adv code needs to improve,
and I'm putting my foot down starting with this change.

If you have a static function which is therefore private to a
source file, name it whatever you want.

But once it gets exported out of that file, you have to give it
an appropriate name.  Probably with a "batman_adv_" prefix or
similar.

Otherwise, for one thing, if this code is statically built into
the tree it can conflict with symbol names elsewhere and break
the build.

Reply via email to