I want to add it's a good idea to make your local changes to the repo in a
git branch. As mentioned, after you make a pull request when you update the
code in your repo, the pull request will update as well. It's possible you
may be working on multiple different patches and you don't want some of
your changes getting co-mingled. If you make a branch for each change
(which is a good practice anyways), then your pull request(s) will be
isolated to the one change.
David
On Mon, May 16, 2016 at 8:00 AM, Mauro Condarelli <mc5...@mclink.it> wrote:
> Hi,
>
> I think a bit of explanation is in order to clarify (Lars please correct
> me if I say something wrong).
>
> Github workflow follows git workflow, which is very different from
> traditional CVS/SVN.
>
> Main difference is you do not "checkout" with git, but You "clone"; this
> means you get a complete
> repository, not just the current (or whatever version you chose to
> checkout).
> You then work with your local copy of the repository until you are
> satisfied,
> finally you publish your work to the outside world.
> I won't go into details of git usage as there are better guide than I could
> write here.
>
> GitHub workflow follows the above concept; you have to:
> 1) open an account on github (that is not your mail, it's a real
> registration on the site).
> my is "mcondarelli"
>
> 2) clone backuppc/backuppc (or whatever else) int your account
> I would have "mcondarelli/backuppc"
>
> 3) work *on your account* cloning from there to your own local disk.
> *your account* will be the "origin" of your working clone.
>
> 4) synchronize *your account* with local workspace ("git push")
>
> 5) repeat (3) and (4) until satisfied.
>
> 6) open a "pull request" on the *original backuppc/backuppc*
> this will come to attention of backuppc/backuppc mainatainers.
>
> 7) maintainers will examine patches, comment on them and, eventually ask
> for revision.
>
> 8) if you update the code on *your account* this will immediately
> reflect on the pull
> request updating it to the new revision. No need to do anything more.
>
> 9) when also maintainers are satisfied with patches they "pull" them
> into the
> main repository which will have a new revision.
> the "pull request" is closed.
>
> 10) at this point you can delete the repo on your account or use it for
> further development.
>
> This kind of workflow is a bit complex, but has several advantages:
>
> a) everyone can directly clone the main directory without further
> requirements.
> b) everyone (with free github account) can submit issues and discuss them.
> c) everyone (with free github account) can submit patches.
> d) maintainers retain control of central repository.
> e) maintainers can request small (or big) changes to patches motivating
> the request.
> f) submitters retain control of the actual patch.
> g) infrastructure at github guides everybody easing the work.
> h) there is no need to give every contributor write access to central
> repository.
> i) there is no need for maintainers to manually incorporate patches.
>
> All this may seem overcomplex, but it's actually longer to explain than to
> do.
>
> It is important people is aware about what the change in infrastructure
> actually means.
> I hope this answers Adam's concerns below.
>
> Regards
> Mauro
>
> Il 16/05/2016 15:33, Adam Goryachev ha scritto:
> >
> > On 16/05/2016 23:06, Alexander Moisseev wrote:
> >> On 16.05.2016 15:50, Adam Goryachev wrote:
> >>> Finally, I've created a github account for myself, I can't promise to
> do
> >>> much, but if I can at least have the ability to submit patches, then
> I'd
> >>> appreciate it. Having never worked with github before (other than
> >>> checking out code to use), is there an ability to have (for example) 10
> >>> people active on the project, where any one of them can submit patches,
> >>> and commit patches, but each user can't commit their own patch? Just to
> >>> ensure some level of community review?
> >> Of course it is.
> > Sorry, as I mentioned, I'm not a github user (until now).
> >
> >> Any GitHub user can make pull requests, but only organization members
> can commit them into the code base.
> > So what you meant is no then? ie, one organisation member can submit a
> > patch *and* commit the same patch, without any sort of review. Sure,
> > others can see the commits, and potentially submit and commit a patch to
> > undo the "erroneous" commit, but not the same as preventing the wrong
> > commit in the first place.
> >
> > Ideally, anyone can submit a patch
> > Ideally, any "approved" person can commit a patch, as long as it isn't
> > their own
> >
> > Could that be done?
> >
> > PS, I think I forgot to include my github account name "adamgoryachev",
> > I can't promise to be terribly helpful, but I do try from time to time.
> >
> > Regards,
> > Adam
> >
>
>
> ------------------------------------------------------------------------------
> Mobile security can be enabling, not merely restricting. Employees who
> bring their own devices (BYOD) to work are irked by the imposition of MDM
> restrictions. Mobile Device Manager Plus allows you to control only the
> apps on BYO-devices by containerizing them, leaving personal data
> untouched!
> https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
> _______________________________________________
> BackupPC-users mailing list
> BackupPC-users@lists.sourceforge.net
> List: https://lists.sourceforge.net/lists/listinfo/backuppc-users
> Wiki: http://backuppc.wiki.sourceforge.net
> Project: http://backuppc.sourceforge.net/
>
--
David Cramblett
------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________
BackupPC-users mailing list
BackupPC-users@lists.sourceforge.net
List: https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki: http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/
