Hi there,
On Sun, 27 Jul 2025, backu...@kosowsky.org wrote:
Love to get some feedback on it first...
Well since you ask...
1. The month in the 'Version' line is wrong:
8<----------------------------------------------------------------------
# Version 0.2 June 2025
#
# CHANGELOG:
# 0.1 (June 2025)
# 0.2 (July 2025)
8<----------------------------------------------------------------------
2. You might need to tell people what to do with this:
8<----------------------------------------------------------------------
use lib "/usr/share/backuppc/lib";
8<----------------------------------------------------------------------
3. and possibly this:
8<----------------------------------------------------------------------
my $bpc = BackupPC::Lib->new('/var/lib/backuppc', undef, undef, 1)
8<----------------------------------------------------------------------
4. When you output "ServerConnect failed" it could be useful to say
why you think it failed.
5. This could be a command-line option or something:
8<----------------------------------------------------------------------
my $lookback_days = 365; # Configurable lookback period for recent backups
8<----------------------------------------------------------------------
6. I find the left justification of all the numbers not very readable,
and I'm not wild about the commas in the numbers but I can live with it.
Configuration options?
7. I'd be inclined to put a decimal digit in the TIME column numbers.
Configuration option?
8. It could be helpful to be able to set (e.g. command line options)
ratios which define what "differ substantially" means for MAX_FILES/
MAX_SIZE and the current values, and to flag any outliers found.
9. It could be really useful to get dates for when the MAX_FILES and
MAX_SIZE values were found. For example, although I've a pretty good
idea why one of my servers was up to 904,000 files at some point but
it's down at around 270,000 now - with hardly any difference in the
SIZE - I'd like to check that I'm right. Maybe a 'verbose' option to
log all that stuff?
10. Generally it's a great piece of work, nicely laid out, very
readable code, and it's probably worth a mention in Github issue #365.
11. I ran it a few times, it seems to work but I didn't stress-test it.
*Now* will you put it in the wiki? :)
--
73,
Ged.
_______________________________________________
BackupPC-users mailing list
BackupPC-users@lists.sourceforge.net
List: https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki: https://github.com/backuppc/backuppc/wiki
Project: https://backuppc.github.io/backuppc/
