Hello Moray, Thanks for the feedback.
Normally, I don't work on the .spec files (though I created the first one many years ago). However, when looking at what we want to do for Enterprise packaging, I decided to divide the packages differently (separate bat build, fix it so that a bat build *always* works, separate docs, separt mtx, add random passwords, ...). I wasn't aware of the logwatch problem, but will look at it. It looks to me like at least part of the problem was caused by a Fedora change, which the packagers may not have noticed, because such changes are not at all obvious. I am sure they will take it into account next time around. In any case, I will look at these points for the spec files which will be distributed with the next release. I'll also look at what went wrong with the password editing. I thought I had fixed the HOSTNAME problem, but what you write makes me believe that it is still broken. And, yes, there is no chance that it will work with just the --with-hostname option, since that is executed when the package is built rather than when it is installed. I will attempt to get all the points you mention straightened out in the next couple of weeks before the release, so at least the released spec files will function. Best regards, Kern On Wednesday 13 January 2010 15:19:41 Moray Henderson (ICT) wrote: > Hi Kern, > > Thanks for the reply. I've had a look at the bacula.spec you sent, and the > really major problem is still there: the applybaculadate script for > logwatch is missing. Installing this rpm onto a server will break > logwatch: > > apptesting:~# logwatch --print --range=today > Cannot find shared script applybaculadate > > which makes the Bacula Team look bad :-( You either need to install that > file into scripts/shared/ or patch conf/services/bacula.conf to comment out > the line that refers to it. > > Earlier versions of RH/Fedora/Centos still use the older version of > logwatch with /etc/log.d as its root, so if you are still going to allow > builds for wb3, rh7, rh8, rh9, fc1, fc3 and fc4 (and there are some of > those around, especially RHEL4) the logwatch root should really be a macro > so that you can switch between /etc/log.d and /etc/logwatch according to > the version you are building for. > > The password setting should work properly now, although line 178 of > bacula-dir.conf gets the placeholder > "XXX_REPLACE_WITH_CLIENT_PASSWORD_XXX2" which just produces the normal > client password with a "2" at the end. > > The hostname setting does not work at the moment: ./configure needs to > replace the 2 macros in the .conf.in files with the XXX_HOSTNAME_XXX > placeholder: > > Name = @basename@ > Address = @hostname@ > > I tried ./configure with the --with-hostname option, but it didn't seem to > make any difference; at the moment I can't see how to make it work. > > > Moray. > "To err is human. To purr, feline" > > >-----Original Message----- > >From: Kern Sibbald [mailto:[email protected]] > >Sent: 12 January 2010 15:41 > >To: [email protected] > >Cc: Moray Henderson (ISO) > >Subject: Re: [Bacula-devel] Fedora/EL builds of 3.0.3 > > > >Hello, > > > >You might want to take a look at the new .spec files that I created some > >time ago. I was hoping the packagers would use them for the 3.0.3 > > release, but they used the old spec. I believe my spec files correct > > most of these problems -- though the doc is still listed as tar.gz -- > > that is easy enough to fix. > > > >Any feedback on these specs would be welcome, because they are the specs > >that will be used to generate the next released version (5.0.0) which > >should come around the end of this month. > > > >I have attached them here for your convenience. They are also in the > >master branch of the SF git repo. > > > >Best regards, > > > >Kern > > > >On Tuesday 12 January 2010 16:12:59 Moray Henderson wrote: > >> Hello Developers, > >> > >> The platforms/redhat/bacula.spec.in file in your 3.0.3 tarball has a > >> number of problems when built for EL5 and sqlite: > >> > >> - Source file bacula-docs is now bz2 not gz > >> - Logwatch location wrong for newer distros > >> - Logwatch applybaculadate script not installed > >> - Sqlite database not created with correct permissions > >> - Passwords not set up correctly in conf files > >> > >> Your published bacula-3.0.3-1.src.rpm fixes the first two, but not the > >> remainder. > >> > >> The attached patch will ensure the correct logwatch locations for the > >> supported Fedora-based distros (I don't know about SuSE or Mandrake) > >> as well as fixing the other issues. > >> > >> I would also vote for having a placeholder in the Name fields of the > >> .conf files, rather than the hostname of the build host. That way the > >> real hostname can be inserted by the %post script in the same way that > >> the passwords are. I'm building for CentOS 5, and will be installing > >> the rpms on several servers, so having all the resources named after > >> my build server isn't very useful default. > >> > >> There's a small mistake in bacula-3.0.3/scripts/logwatch/README: it > >> tells you to copy scripts/logwatch/bacula to applybaculaupdate. > >> > >> I hope you find this useful. > >> > >> > >> Moray. > >> "To err is human. To purr, feline" > > --------------------------------------------------------------------------- >--- This SF.Net email is sponsored by the Verizon Developer Community > Take advantage of Verizon's best-in-class app development support > A streamlined, 14 day to market process makes app distribution fast and > easy Join now and get one step closer to millions of Verizon customers > http://p.sf.net/sfu/verizon-dev2dev > _______________________________________________ > Bacula-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/bacula-devel ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
