The fixes look good to me.
Regarding the log filtering I had not really seen the role of loglist.

/dba/logs?loglist=%2Fbenchx

Gives me what I wanted, but the what I would like to see is that url to
also show the results from the first log in loglist. As a user this is what
I want to see most of the time.

/Andy


On 10 June 2015 at 23:23, Christian Grün <christian.gr...@gmail.com> wrote:

> Hi Andy,
>
> Good to see it was mostly peanuts [1]. The snapshot will be available
> in a few minutes..
>
> > 1. Login field tab order.
>
> Done.
>
> > 2. logs
> >    There is a little bug in the log sorting function.
>
> Done.
>
> > Also it would be nice if urls for the log display would use any supplied
> > query parameter for initial filtering  e.g going to
> >
> >  /dba/logs?name=2015-06-09&resource=&sort=&loglist=&query=%2Fmyapp%2F
>
> Currently, it's possible to look for a string in both the log list and
> the chosen log file (the key for that is "loglist"). Or would you
> rather be able to look for different strings?
>
> > I should get a PR together but that might be some time.
>
> Obviously, future PRs are always welcome ;) And in general, we are
> interested in hearing more about what you (and others) think about the
> DBA interface.
>
> Best,
> Christian
>
> [1]
> https://github.com/BaseXdb/basex/commit/7b5483bcb749696551f0a46416bdecdfc35a52f3
>

Reply via email to