https://issues.apache.org/bugzilla/show_bug.cgi?id=42395

Mario <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #5 from Mario <[email protected]> ---
Still found this to be true in the latest sources from SVN (i.e. 1.8pre). With
a little digging I found that the paintDecorations(List, Graphics2D, int) in
the StrokingTextPainter class did not check the TextPaintInfo.visible property
at all. The paintDecorations method takes care of painting the underline,
overline and strikethrough decorations. The TextPaintInfo instance is retrieved
from the AttributedCharacterIterator instance from every TextRun object (i.e.
basically 'chunks' of consecutive characters sharing the same style).
I placed a check on the TextPaintInfo.visible property (relating to the SVG
visibility property) before the decoration is finally painted.
As far as I can see it that solved this bug. I tried the test case provided in
the attachments as wel as several tests of my own via the Squiggle browser and
they all passed.

I've attached the patch for StrokingTextPainter.java.

I'd be happy to commit the source to the repository, but I don't know what the
policy is for this project? I assume that not any random individual with a
bugtracker account can commit? ;)

I would say with the attached patch status of this bug is: 'WORKSFORME'.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to