https://issues.apache.org/bugzilla/show_bug.cgi?id=42395

Helder Magalhães <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WORKSFORME                  |---

--- Comment #6 from Helder Magalhães <[email protected]> ---
(In reply to comment #5)
> I placed a check on the TextPaintInfo.visible property (relating to the SVG
> visibility property) before the decoration is finally painted.
> As far as I can see it that solved this bug. I tried the test case provided
> in the attachments as wel as several tests of my own via the Squiggle
> browser and they all passed.
> 
> I've attached the patch for StrokingTextPainter.java.

Thanks for your contribution! :-)

I've taken a quick look and it seems fine, although I'd ask someone more
familiar with that code to take a look if possible. Thomas?


> I'd be happy to commit the source to the repository, but I don't know what
> the policy is for this project? I assume that not any random individual with
> a bugtracker account can commit? ;)

The policy is public [1] and, basically, meritocracy-based (the Apache way) and
things a done in the open. Basically this means that if the changes were many,
you'd have to sign a document (ICLA [2]) in order for us to be able to accept
the patch. As in this case the changes are small, any team member can commit
once sure it won't break anything.


> I would say with the attached patch status of this bug is: 'WORKSFORME'.

Nope. "Works for me" [3] means the problem can't be reproduced, and there's not
enough information to provide a fix based on the facts. Please take a look at
the different issue states and their meaning before changing them. ;-)


[1] http://www.apache.org/foundation/getinvolved.html
[2] http://www.apache.org/dev/new-committers-guide.html
[3] https://issues.apache.org/bugzilla/page.cgi?id=fields.html#status

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to