Ronan has revoked my CVS write privileges, so I cannot commit the bug fix which is appended to this message. I would appreciate if someone with write privileges could do that. The official cause for the revocation is the following patch: -;; Hook in GUI hacks -(or (eq window-system nil) - (add-hook 'bbdb-list-hook 'bbdb-fontify-buffer)) +(defcustom bbdb-gui (not (null window-system)) + "*Should the *BBDB* buffer be fontified? +This variable has no effect if set outside of customize." + :group 'bbdb + :type 'boolean + :set (lambda (symb val) + (set symb val) + (if val + (add-hook 'bbdb-list-hook 'bbdb-fontify-buffer) + (remove-hook 'bbdb-list-hook 'bbdb-fontify-buffer)))) The code, which I replaced, forced the user into bbdb-gui whenever emacs was running under a window system, unless a user took an action removing the hook _after_ loading bbdb.el. I believe that this change was a bug fix, since customize is the standard way to specify user options in both Emacs & XEmacs, and since forcing the user to take additional action after loading a file is a hassle. Since Ronan did assert that he wished more of BBDB to be customizable, I was surprised that he got upset at this change. At any rate, he could always override my patch (he still did not do that - maybe the change was not that bad, after all? :-) I have been using BBDB for 6 years and contributing to development for over 3 years, and I believe kicking me out was unwarranted (in general, removing an old-time developer from a project without his consent is not a nice thing to do). This does not correspond well with the idea of _cooperative_ development. I find it very inconvenient to submit patches over e-mail (strangely enough, e-mail is the bottleneck of my Internet connection), so I will probably concentrate on other projects. -- Sam Steingold (http://www.podval.org/~sds) If I had known that it was harmless, I would have killed it myself. 2001-02-21 Sam Steingold <[EMAIL PROTECTED]> * lisp/bbdb-gnus.el (bbdb/gnus-edit-notes, bbdb/gnus-show-sender): call `bbdb/gnus-pop-up-bbdb-buffer' instead of `bbdb/gnus-update-record' (bbdb/gnus-pop-up-bbdb-buffer): use `gnus-buffer-configuration' instead of the obsolete `gnus-window-configuration'. --- bbdb-gnus.el.~1.71.~ Fri Oct 27 14:32:06 2000 +++ bbdb-gnus.el Wed Feb 21 17:26:33 2001 @@ -89,8 +89,7 @@ of the BBDB record corresponding to the sender of this message." (interactive "P") (gnus-summary-select-article) - (let ((record (or (bbdb/gnus-update-record t) (error "")))) - (bbdb-display-records (list record)) + (let ((record (or (bbdb/gnus-pop-up-bbdb-buffer t) (error "unperson")))) (if arg (bbdb-record-edit-property record nil t) (bbdb-record-edit-notes record t)))) @@ -98,13 +97,11 @@ ;;;###autoload (defun bbdb/gnus-show-sender () "Display the contents of the BBDB for the sender of this message. -This buffer will be in bbdb-mode, with associated keybindings." +This buffer will be in `bbdb-mode', with associated keybindings." (interactive) (gnus-summary-select-article) - (let ((record (bbdb/gnus-update-record t))) - (if record - (bbdb-display-records (list record)) - (error "unperson")))) + (or (bbdb/gnus-pop-up-bbdb-buffer t) + (error "unperson"))) (defun bbdb/gnus-pop-up-bbdb-buffer (&optional offer-to-create) @@ -114,32 +111,30 @@ (record (bbdb/gnus-update-record offer-to-create)) (bbdb-electric-p nil)) - (if bbdb-use-pop-up + (when bbdb-use-pop-up (let ((bbdb-elided-display (bbdb-pop-up-elided-display)) (b (current-buffer))) ;; display the bbdb buffer iff there is a record for this article. - (cond (record + (if record (bbdb-pop-up-bbdb-buffer - (function (lambda (w) + (lambda (w) (let ((b (current-buffer))) (set-buffer (window-buffer w)) (prog1 (or (eq major-mode 'gnus-Article-mode) (eq major-mode 'gnus-article-mode)) - (set-buffer b))))))) - (t + (set-buffer b))))) (or bbdb-inside-electric-display (not (get-buffer-window bbdb-buffer-name)) (let (w) (delete-other-windows) - (if (assq 'article gnus-window-configuration) ; 3.15+ + (if (assq 'article gnus-buffer-configuration) (gnus-configure-windows 'article) (gnus-configure-windows 'SelectArticle)) (if (setq w (get-buffer-window (if (boundp 'gnus-summary-buffer) gnus-summary-buffer gnus-Subject-buffer))) - (select-window w)) - )))) + (select-window w))))) (set-buffer b))) (if record (bbdb-display-records (list record))) record)) _______________________________________________ [EMAIL PROTECTED] http://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
