On 17 Apr 2011, Roland Winkler verbalised:

> On Sun Apr 17 2011 Nix wrote:
>> (Actually I went further and had it work for each message *for each
>> function*, so if you put it on the hook a dozen times it still only got
>> called once. But this is a useless and arguably confusing side-effect of
>> the behaviour I really wanted. If you only want your function called
>> once, don't put it on the hook twice!)
>
> Agreed. It's my understanding that a major point in having the
> function add-hook is that you can call it without worrying whether
> the function you want to add to a hook is already present.

True enuff.

>> I'd be inclined to say that the existing hook should have been
>> called bbdb-notice-address-hook, so the new one could get called
>> bbdb-notice-record-hook, but of course we can't rename that hook
>> without breaking everyone's setups.
>
> I am inclined to making this change anyway, a reason being that the
> difference between these hooks was previously not spelled out, so
> that with the new BBDB people have to redecide what they really
> want.

Is it *that* different? We could keep an alias... but I'm inclined
to say it doesn't matter as well. Break compatibility and damn the
torpedoes! :)

>                             Also, I cleaned up the code that allows
> bbdb-notice-(address)-hook to identify the address in the message so
> that any such hook functions need to be updated, too.

That might be useful.

> Thank you!

Note that I didn't say I'd actually done any work on it yet. ;}

-- 
NULL && (void)

------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/

Reply via email to