Fletch;250648 Wrote: 
> I'll work up a patch for #2 and the spec patching issue since they're
> slightly interrelated.

Matt,

I'm working on a patch for this and I noticed something that I don't
understand:


Code:
--------------------
    @@ -70,11 +70,15 @@
                showUsage();
        }
  
  -     my $prefix = $^O eq 'linux' ? 'SlimServer' : 'SqueezeCenter';
  +     my $prefix = $^O eq 'linux' ? 'SqueezeCenter' : 'SqueezeCenter';
        
        if ($snapshot) {
  
  -             $version = strftime('%Y-%m-%d', localtime());
  +             ## If we're doing a snapshot, but a version has been explicitly 
  +             ## configured, always use the explicitly configured data.
  +             if (!$version) { 
  +                     $version = strftime('%Y-%m-%d', localtime());
  +             }
  
                if ($branch) {
                        $title      = "${prefix}_${branch}_v$version";
--------------------


This seems to mean that if I run makerelease.pl with "--snapshot
--version 7.0.0" the tarball will be built as
SqueezeCenter_trunk_v7.0.0.tar.gz instead of
SqueezeCenter_trunk_v2007-12-21.tar.gz.  That's not really the intended
result, is it?


-- 
Fletch
------------------------------------------------------------------------
Fletch's Profile: http://forums.slimdevices.com/member.php?userid=529
View this thread: http://forums.slimdevices.com/showthread.php?t=41217

_______________________________________________
beta mailing list
beta@lists.slimdevices.com
http://lists.slimdevices.com/lists/listinfo/beta

Reply via email to