Hi again, > - Vertical sensor size has got no affect What I have tried to explain on the patch tracker, is that the vertical sensor size affects the vertical fov, based on the focal length. If you have a sensors height and the vfov in degrees/radians (from an imported file) you get the correct focal length. Blender has used the horizontal fov to set the focal length with this principle, using the fixed 32 x18 mm "sensor". Some programs uses/exports the hfov but some uses the vfov, and if they do you need to set the used vertical sensor size, to return the correct focal length. Obviously this works the other way (sensor x/y & focal = hori/vert fov) for exporters.
> - Exportters also weren't handling sensor size correct Which exporters didn't handle sensor size correctly and in what programs? As it is now, I can only test formats with software I have access to, and that means I mostly worked on FBX export... I have tested FBX on Maya 2008+2011, Nuke and Houdini, where sensor size, focal length and fov are exported as they should. The other importer/exporter I focused on is the very simple .chan that works in Nuke: http://dl.dropbox.com/u/11299813/io_anim_chan.py I thought there would be problems in other exporters, but again can't test them directly yet. I would like to work on Collada but don't know how. Do you know any app on Linux I can test the (Collada) camera import/export with? Thanks for looking on this, and for your cool work in GSoC! Best regards, Ejner On Mon, May 30, 2011 at 6:26 PM, Sergey I. Sharybin <g.ula...@gmail.com> wrote: > Hi, > > I've reviewed patch and the only things which are confusing me: > - Vertical sensor size has got no affect > - Exportters also weren't handling sensor size correct (they were using > default or so) > > Problem that it's not actully areas of code i've been working before so > patch should be reviewed by somebody more familiar with this areas. > > I could only say that functionality looks useful for me (due to my > camera-tracking related job atm) and i haven't noticed serious issues > with code style. > > Ejner Fergo wrote: >> Hola, >> >> I have updated the patch to revision 37009: >> http://projects.blender.org/tracker/index.php?func=detail&aid=24427&group_id=9&atid=127 >> >> I have also written a short documentation: >> http://wiki.blender.org/index.php/User:San/Real_Focal_Length >> >> About code review, I think I read that only committers can upload to >> the code review tool? The patch is assigned to Sergey Sharybin >> (nazgul) so hopefully he reads this and have the time to do it. I'm >> aware that GSOC is in full swing, but still think this patch will be >> good to have in 2.58. >> >> I am prepared to work more on importers/exporters and have so far made >> good progress on FBX and .chan and will do my best to make every >> script having to do with cameras work with this new code. >> >> Best regards, >> >> Ejner >> >> On Wed, Apr 27, 2011 at 9:08 AM, "Martin Bürbaum" >> <martin.buerb...@gmx.at> wrote: >>> Ejner Fergo<ejner...@gmail.com> wrote: >>>> I am of course hopeful to see this get some attention from the >>>> developers, and appreciate you guys seeing the importance of this. I >>>> just don't know how to proceed with this to make an inclusion in trunk >>>> more likely. It would be really nice to hear some opinions from those >>>> with authority. >>> I am not a blender developer (sorry, no authority here), but I think a good >>> start would be to upload the latest patch to the code review tool [1]. >>> And link that in the bug tracker. (<? I don't know about the exact >>> procedures here.) >>> >>> Then it's pretty easy to review and comment on the patch, which in turn >>> will speed up its integration into trunk, I presume. >>> >>> Saludos, >>> Martin >>> >>> [1] http://codereview.appspot.com >>> Example Review: http://codereview.appspot.com/4280080 >>> Mailing List: http://lists.blender.org/pipermail/bf-codereview/ >>> _______________________________________________ >>> Bf-committers mailing list >>> Bf-committers@blender.org >>> http://lists.blender.org/mailman/listinfo/bf-committers >>> >> _______________________________________________ >> Bf-committers mailing list >> Bf-committers@blender.org >> http://lists.blender.org/mailman/listinfo/bf-committers >> > > > -- > With best regards, Sergey I. Sharybin > > _______________________________________________ > Bf-committers mailing list > Bf-committers@blender.org > http://lists.blender.org/mailman/listinfo/bf-committers > _______________________________________________ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers