[
https://issues.apache.org/jira/browse/BIGTOP-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129376#comment-13129376
]
Bruno Mahé commented on BIGTOP-25:
----------------------------------
I am not really comfortable having some java auto-detection code in
/etc/default.
That said, do we really want to auto-detect java instead of using the default
one, which is supposedly the one the user want to use? But either way, we would
need a way to extract the java home from there.
Regarding the autodetection code, here are some additional ideas:
* We put it in a wrapper for each binary that needs it. And ideally open a
ticket upstream so they can fix it directly
* We create a package named something like "bigtop-utils" which would put that
file somewhere on the filesystem (ex: /usr/libexec) and make scripts source it.
This way, the code would not need to be duplicated, and be easily updated as
needed.
> Standardize JAVA_HOME detection
> -------------------------------
>
> Key: BIGTOP-25
> URL: https://issues.apache.org/jira/browse/BIGTOP-25
> Project: Bigtop
> Issue Type: Bug
> Components: General
> Affects Versions: 0.1.0
> Reporter: Roman Shaposhnik
> Assignee: Roman Shaposhnik
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: bigtop-javahome
>
>
> The Hadoop packages go through some effort (see
> /usr/lib/hadoop-0.20/bin/hadoop-config.sh) to guess at a good JVM to use if
> JAVA_HOME isn't set. For example, if both OpenJDK and Oracle JDK are
> installed, hadoop-config.sh will choose Oracle every time. Other packages
> that Bigtop integrates, don't follow the same practice (ZK, Pig, etc.). It
> would be nice to have this common code shared.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
