[
https://issues.apache.org/jira/browse/BIGTOP-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133533#comment-13133533
]
Roman Shaposhnik edited comment on BIGTOP-25 at 10/23/11 12:50 AM:
-------------------------------------------------------------------
Looks good in general. +1. A couple of nitpicks before you commit, though:
* can we use Bigtop as a moniker instead of bigTop or any other kinds of
capitalization? when used in mailing list/http URLs lets use bigtop
* you sure about /usr/libexec and not something like /usr/lib/bigtop-utils/ ?
* lots of references to HBase in the deb/.../copyright. cut-n-paste errors?
* rpm/bigtop-utils/SPECS/.gitignore has weird content
* would it make more sense to version this package together with Bigtop IOW,
BIGTOP_UTILS_BASE_VERSION=BIGTOP_VERSION ?
P.S. Really liked this line: BuildRoot: %(mktemp -ud
%{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
And thanks for taking care of Cloudera references. I actually have a JIRA to
clean it up even more.
was (Author: rvs):
Looks good in general. +1. A couple of nitpicks before you commit, though:
* can we use Bigtop as a moniker instead of bigTop or any other kinds of
capitalization? when used in mailing list/http URLs lets use bigtop
* you sure about /usr/libexec and not something like /usr/lib/bigtop-utils/ ?
* lots of references to HBase in the deb/.../copyright. cut-n-paste errors?
* rpm/bigtop-utils/SPECS/.gitignore has weird content
* would it make more sense to version this package together with Bigtop IOW,
BIGTOP_UTILS_BASE_VERSION=BIGTOP_VERSION ?
*
P.S. Really liked this line: BuildRoot: %(mktemp -ud
%{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
And thanks for taking care of Cloudera references. I actually have a JIRA to
clean it up even more.
> Standardize JAVA_HOME detection
> -------------------------------
>
> Key: BIGTOP-25
> URL: https://issues.apache.org/jira/browse/BIGTOP-25
> Project: Bigtop
> Issue Type: Bug
> Components: General
> Affects Versions: 0.1.0
> Reporter: Roman Shaposhnik
> Assignee: Bruno Mahé
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments:
> 0001-BIGTOP-25.-Add-a-new-bigtop-utils-package-which-prov.patch,
> bigtop-javahome
>
>
> The Hadoop packages go through some effort (see
> /usr/lib/hadoop-0.20/bin/hadoop-config.sh) to guess at a good JVM to use if
> JAVA_HOME isn't set. For example, if both OpenJDK and Oracle JDK are
> installed, hadoop-config.sh will choose Oracle every time. Other packages
> that Bigtop integrates, don't follow the same practice (ZK, Pig, etc.). It
> would be nice to have this common code shared.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
