[ 
https://issues.apache.org/jira/browse/BIGTOP-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247656#comment-13247656
 ] 

Roman Shaposhnik commented on BIGTOP-483:
-----------------------------------------

David, first of all thanks for being persistent on this issue. Some of this 
dates back to the most ancient time of iTest ever so please don't take it as a 
final truth written in stone. Essentially, the fact that we've always had it 
that way doesn't mean we shouldn't change it.

That said, the issue really boils down to whether we:
  # try to essentially fork the testConf.xml from upstream and maintain it in 
Bigtop
  # try to work with upstream to make testConf.xml not only applicable to the 
true unit tests, but also in a more generic system test context (what Bigtop 
does)

Of course number 2 has an advantage of HDFS developers maintaining it for us 
according to whatever changes they make to the source code of HDFS, but we have 
to make sure that there's nothing in there that is miniDFS specific (IOW hard 
coded assumptions that are going to break on a real cluster).
                
> Smoke test of Hadoop fails with clitest missing testConf.xml file
> -----------------------------------------------------------------
>
>                 Key: BIGTOP-483
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-483
>             Project: Bigtop
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 0.3.0
>         Environment: Found on ubuntu, but applies to all systems.
>            Reporter: David Liu
>            Assignee: Roman Shaposhnik
>             Fix For: 0.4.0
>
>         Attachments: BIGTOP-483.patch.txt
>
>
> 12/03/21 23:10:05 INFO cli.TestCLI: File: 
> /home/ubuntu/bigtop/bigtop-tests/test-execution/smokes/hadoop/target/clitest_data/testConf.xml
>  not found
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.923 sec <<< 
> FAILURE!
> Results :
> Failed tests: 
>   testAll(org.apache.bigtop.itest.hadooptests.TestTestCLI)
> Tests run: 10, Failures: 1, Errors: 0, Skipped: 0
> More details:
> -------------------------------------------------------------------------------
> Test set: org.apache.bigtop.itest.hadooptests.TestTestCLI
> -------------------------------------------------------------------------------
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.923 sec <<< 
> FAILURE!
> testAll(org.apache.bigtop.itest.hadooptests.TestTestCLI)  Time elapsed: 0.096 
> sec  <<< FAILURE!
> junit.framework.AssertionFailedError: Error reading test config file
>         at junit.framework.Assert.fail(Assert.java:47)
>         at junit.framework.Assert.assertTrue(Assert.java:20)
>         at org.apache.hadoop.cli.TestCLI.readTestConfigFile(TestCLI.java:105)
>         at org.apache.hadoop.cli.TestCLI.setUp(TestCLI.java:114)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to