[ 
https://issues.apache.org/jira/browse/BIGTOP-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247799#comment-13247799
 ] 

David Liu commented on BIGTOP-483:
----------------------------------

Digging further, it seems the real issue is iTest's TestCLI.groovy tries to use 
System.properties.setProperty() to change the xml file name to 
testConfCluster.xml, but that doesn't work, as the base class is using 
bigtop/build/hadoop/deb/hadoop-1.0.1/src/test/org/apache/hadoop/cli/TestCLI.java
 which has 
static String testConfigFile = "testConf.xml";
This code as is should work well if tests are from 
https://github.com/apache/hadoop-common/blob/branch-0.22/common/src/test/core/org/apache/hadoop/cli/CLITestHelper.java#L85

But I am not clear, how to attach branch-0.22's test code to bigtop, or whether 
that is possible. 

I am not versed in the history of the test setup, and too new to comment on the 
right approach. But I sure hope bigtop has its own set of minimal set of 
testing for each sub project that has no upstream dependencies just to verify 
the basic health of the build and setup.

                
> Smoke test of Hadoop fails with clitest missing testConf.xml file
> -----------------------------------------------------------------
>
>                 Key: BIGTOP-483
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-483
>             Project: Bigtop
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 0.3.0
>         Environment: Found on ubuntu, but applies to all systems.
>            Reporter: David Liu
>            Assignee: Roman Shaposhnik
>             Fix For: 0.4.0
>
>         Attachments: BIGTOP-483.patch.txt
>
>
> 12/03/21 23:10:05 INFO cli.TestCLI: File: 
> /home/ubuntu/bigtop/bigtop-tests/test-execution/smokes/hadoop/target/clitest_data/testConf.xml
>  not found
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.923 sec <<< 
> FAILURE!
> Results :
> Failed tests: 
>   testAll(org.apache.bigtop.itest.hadooptests.TestTestCLI)
> Tests run: 10, Failures: 1, Errors: 0, Skipped: 0
> More details:
> -------------------------------------------------------------------------------
> Test set: org.apache.bigtop.itest.hadooptests.TestTestCLI
> -------------------------------------------------------------------------------
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.923 sec <<< 
> FAILURE!
> testAll(org.apache.bigtop.itest.hadooptests.TestTestCLI)  Time elapsed: 0.096 
> sec  <<< FAILURE!
> junit.framework.AssertionFailedError: Error reading test config file
>         at junit.framework.Assert.fail(Assert.java:47)
>         at junit.framework.Assert.assertTrue(Assert.java:20)
>         at org.apache.hadoop.cli.TestCLI.readTestConfigFile(TestCLI.java:105)
>         at org.apache.hadoop.cli.TestCLI.setUp(TestCLI.java:114)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to