Tushar, I have two failures with popt's make check. Tests 27 and 28 fail. It is not hard to change the testit.sh script to make the tests pass. It would seem like an error in the testing script to me. ***Not. See Below.
old: run test1 "test1 - 27" "arg1: 0 arg2: (none) -" - run test1 "test1 - 28" "arg1: 0 arg2: foo -" - -2 foo fixed: run test1 "test1 - 27" "arg1: 0 arg2: (none) rest: -" - run test1 "test1 - 28" "arg1: 0 arg2: foo rest: -" - -2 foo When you did the testing for popt, did you see this? http://linuxfromscratch.org/pipermail/blfs-dev/2006-January/013051.html I also checked out popt from redhat's cvs and testit.sh has not changed, so it may be somthing we (I) am doing. After doing more research, I found that the following patch fixes the tests: diff -Naur popt-1.10.4/popt.c popt/popt.c --- popt-1.10.4/popt.c 2005-11-15 18:07:15.000000000 -0600 +++ popt/popt.c 2003-12-26 20:40:25.000000000 -0600 @@ -748,9 +748,7 @@ if (origOptString == NULL) /* XXX can't happen */ return POPT_ERROR_BADOPT; - if (con->restLeftover || *origOptString != '-' || - (*origOptString == '-' && origOptString[1] == '\0')) - { + if (con->restLeftover || *origOptString != '-') { if (con->flags & POPT_CONTEXT_POSIXMEHARDER) con->restLeftover = 1; if (con->flags & POPT_CONTEXT_ARG_OPTS) { I got this by pulling the current cvs version and doing a diff. We might get away with a sed: sed -i -e "/*origOptString ==/c 0)" popt.c The result is not very pretty, but it works. If you could integrate this into the book, I'd appreciate it. Also, please change the SBU time from 0.29 to 0.3. We changed the policy some time ago on SBU times: less than 0.1 0.1 to 19.9 20 and up Thanks. -- Bruce -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
