On 01/15/2013 10:27 PM, Tobias Gasser wrote: > removing the expose_snapshot-patch seems to be a bad idea! > > > making xulrunner 18.0 fails with: > > > gfxUtils.cpp > /tmp/mol-firefox.39CfnUpL.w/mozilla-release/gfx/thebes/gfxPlatform.cpp: > In member function 'virtual mozilla::RefPtr<mozilla::gfx::SourceSurface> > gfxPlatform::GetSourceSurfaceForSurface(mozilla::gfx::DrawTarget*, > gfxASurface*)': > /tmp/mol-firefox.39CfnUpL.w/mozilla-release/gfx/thebes/gfxPlatform.cpp:630:53: > error: 'cairo_null_surface_create' was not declared in this scope > /tmp/mol-firefox.39CfnUpL.w/mozilla-release/gfx/thebes/gfxPlatform.cpp:635:95: > error: 'cairo_surface_attach_snapshot' was not declared in this scope > > In the directory > /tmp/mol-firefox.39CfnUpL.w/mozilla-release/xulrunner-build/gfx/thebes > > > > rebuilding cairo with the patch and then building xulrunner finishes > without any error. > > i did not try to build 16.0.1 as 18.0 compiled fine before i removed the > cairo patch - and compiles fine again with the patch. > > > > tobias > >
I'm pretty sure that I removed --enable-system-cairo from Mozilla products' instructions. The patch was originaly written for an older version of Cairo (maybe even pre-1.10). Andy modified the patch to apply against Cairo 1.12.0 at the time, but when 1.12.4 came out - it had some great changes and porting it wasn't so easy. I could get patch to apply and Firefox/Thunderbird to build. Then I started to get strange results at runtime, like Firefox crashing, embedded videos couldn't be seen on some pages and Thunderbird dumping core at shutdown with backtrace to cairo libraries. When I rebuild both of them without system cairo, all of the mentioned errors were gone, so I decided to remove the patch untill we come up with something else. -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
